Comments (13)
probably something fairly simple. probably should be looking at the button "value" rather than its "id" in PortraitDragOp
and Button::CompleteDragOperation
i forget the details.
from gemrb.
if thats not it, a cursory glance suggests that we can simply swap the frames of the buttons (after SwapPCs) :)
from gemrb.
that's just dragging — like I said, no mouse interaction works.
from gemrb.
yes, but nobody has yet looked into what you mean by that yet :)
are you saying that Window::DispatchMouseMotion
never creates a drag event? lots of possibilities on how it "doesn't work".
from gemrb.
I haven't looked at dragging at all, since that's so rarely used. I saw that clicking doesn't work and from there it was obvious to try rightclicking and dragging. Then I wrote the report and continued the exploration I was in the middle of. The window basically behaves like it had a painted background, not controls.
from gemrb.
ok, i'll investigate further.
from gemrb.
dragging works, but now there is a label over the button so it is getting dragged...
pretty sure that label has always been there so i'm not quite sure how this was working before (Im certain it was, it was the test case when this was developed)
from gemrb.
Ah. In master, all labels are like that, so you can default to it.
from gemrb.
Only right-clicking remains, but that is another victim of overzealous code removal on the py side.
from gemrb.
I prefer to label it as underzealous cleanup ;)
from gemrb.
I'll have time later today to look at it; the initial thing I found is unrelated.
from gemrb.
ok, it was the same rightclick binding bug (#33). That's just the first hurdle though, as the passed button has an insanely big ID. Checking what that's about ...
Looks like it's the default python object id, not what the function wants to get, which is the party id. Trivial to mend back.
from gemrb.
since it's from 961ef20, this likely affects item dragging to others. Crashy, so no quick test possible.
from gemrb.
Related Issues (20)
- inventory: unusuable items blink the whole overlay HOT 5
- Crash on moving the cursor badly while loading HOT 5
- Crash after BG2 switch screen HOT 3
- More Efficient Text Rendering HOT 1
- SDL2: items drawn over fog HOT 5
- Map Fog drawing tanks performance HOT 5
- Convert `Point` from short -> int HOT 1
- msgwin causes optwin and/or portraitwin drawing issue HOT 8
- can't use enter to move through dialog HOT 14
- soa intro shows broken fades HOT 5
- looting the painting container reliably crashes HOT 1
- odd hotkey crash HOT 6
- rightclicking on msgwin TA shows textedit cursor HOT 3
- f1-f12 hotkeys not working for actionbar actions
- tooltip text: eating up newlines / bad width calc HOT 3
- SDL1: movement target reticles drawn incorectly
- no easy way to reset the action bar HOT 2
- trying to worldmap travel triggers an assert HOT 1
- Assertion `key.character == 0' failed HOT 1
- scroll bams not displaying in shops HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gemrb.