Exclusive Gateway Rendering without marker about bpmn-js HOT 11 CLOSED

I can reproduce your issue. Despite dedicated handling for it the marker is always shown.

I presume this is due to a bug in our model import.

from bpmn-js.

Changing this to a bug report, as it is against the intended, and implemented behavior. We aim to empower the user.

from bpmn-js.

I presume this is due to a bug in our model import.

Never mind this. We actually (unnecessarily) force isMarkerVisible=true during modeling.

Happy to take a contribution that fixes it in the ElementFactory + adds test coverage.

from bpmn-js.

@barmac Today I noticed that this doesn't work in the latest release, even though my contribution is included. Seems we both forgot to check the diagram after the final changes.

It looks like the simplification is the cause of this, see

The original code makes rendering work.

    } else {
      attrs = applyAttribute(di, attrs, 'isMarkerVisible');
      if (di.isMarkerVisible === undefined) {
        di.isMarkerVisible = true;
      }
    }

What is the best way forward to fix this?

from bpmn-js.

Thanks for sharing, I will look into this.

from bpmn-js.

Does it really not work though? I experimented with the following context pad code:

        'append.gateway': appendAction(
          'bpmn:ExclusiveGateway',
          'bpmn-icon-gateway-none',
          translate('Append gateway')
        ),
        'append.gateway1': appendAction(
          'bpmn:ExclusiveGateway',
          'bpmn-icon-gateway-none',
          translate('Append gateway'),
          { isMarkerVisible: undefined }
        ),

which allowed to create both types of gateway:

from bpmn-js.

@barmac Thanks for getting back to this.

My expectation is that the marker is hidden for existing gateways that have isMarkerVisible=false. This doesn't work when I open an existing model, see test/fixtures/bpmn/draw/xor.bpmn in bpmn.io

I guess the same will happen to your model once you save and re-open it.

from bpmn-js.

In the test on main it looks OK though:

I will make sure that the demo.bpmn.io is up to date so that we can verify outside of local environment.

from bpmn-js.

OK I can reproduce it with the current version of bpmn-js.

from bpmn-js.

I guess the same will happen to your model once you save and re-open it.

So the isMarkerVisible is overridden once the XML is exported.

from bpmn-js.

Closed via #2102

from bpmn-js.