Code Monkey home page Code Monkey logo

Comments (4)

bpierre avatar bpierre commented on May 21, 2024 1

You’re absolutely right! It is fixed in 2.4.1 https://github.com/bpierre/dnum/releases/tag/v2.4.1

Thanks for reporting it 🙏

from dnum.

bpierre avatar bpierre commented on May 21, 2024 1

Pulished as 2.5.0, thank you 🙏 https://github.com/bpierre/dnum/releases/tag/v2.5.0

from dnum.

devnomic avatar devnomic commented on May 21, 2024

Seems there is bug, when decimals is zero it doesn't work

const a = [0n, 0]
dn.format(a, { digits: 2, trailingZeros: true }) 
// Result: 0
// Expected: 0.00

const b = dn.from(5); // [5n,0]
dn.format(b, { digits: 2, trailingZeros: true }) 
// Result: 5
// Expected: 5.00

It only works if decimals > 0

const c = [0n, 1]
console.log(dn.format(c, { digits: 2, trailingZeros: true }));
// Result: 0.00
// Expected: 0.00

from dnum.

bpierre avatar bpierre commented on May 21, 2024

Ah yes, it’s a bit of a weird case because if the decimals are lower than digits and trailingZeros is true, then the difference in digits will always show as a series of 0. But I agree we should respect digits and trailingZeros, it makes more sense. Doing the change!

from dnum.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.