Comments (10)
Yes, I followed your guidelines to replace the location history to authorize. I use it in my project: https://github.com/pnlpal/dictionaries, though it's a popup window type, but still it's a window. No new tab or new window. I also suspect it's a bug, my env is Firefox 82.0.2-1 on Manjaro Linux.
I will have more test, and will tell you more what i find. Thank you.
from js-pkce.
Can you please give me a link to the part of your code where this library is being used?
from js-pkce.
https://github.com/pnlpal/dictionaries/blob/master/src/content/music-player.coffee#L41-L72
It's in coffee script, kind of like python.
when click on authorize, the function authorize
will be called, so the flow begins.
from js-pkce.
@bpedroza oh no, my bad. I found the problem. I use it in an iframe, then change the location of the top window.
from js-pkce.
Thanks. I'll check it out. Please continue your own testing and let me know what you find.
from js-pkce.
Ah, that makes sense. Can you work around on your end?
from js-pkce.
I guess that's why the sessionStorage is freed. Somehow chrome is not like that.
from js-pkce.
yeah, it's should be my problem. Somehow this modular is not working on Firefox anyway...
Thanks for helping though, I guess this is a interesting way to debug.
from js-pkce.
Sure. If you're having more issues with firefox, please let me know. I want this package to work for all modern browsers, and if sessionStorage is going to continue to be a problem, maybe we can introduce a way to swap storage types.
from js-pkce.
sure.
from js-pkce.
Related Issues (14)
- `dist/PKCE.d.ts` is missing HOT 2
- PKCE.exchangeForAccessToken function return type is infered as Promise<any> HOT 8
- If I set state in using additionalParams object in authorizeUrl method then after checking response with exchangeForAccessToken I get error 'Invalid State' HOT 5
- token revoke HOT 1
- could you please export ITokenResponse interface from PKCE.d.ts ? HOT 3
- getting JSON parse error while running npm audit HOT 1
- not getting email data from requested scopes HOT 1
- Uncaught (in promise) Error: Cannot resolve "crypto" from ... HOT 3
- How can I get CSRF before exchangeForAccessToken? HOT 1
- Support for custom params HOT 5
- id token HOT 4
- Not usable from browser extensions due to usage of Storage API HOT 2
- Add configuration to allow sending credentials HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from js-pkce.