Code Monkey home page Code Monkey logo

Comments (2)

jenkoian avatar jenkoian commented on July 1, 2024

I was about to raise a similar issue, it might be different to what @klj613-boxuk is referring to but here are the details none the less.

When you grab a patch of a PR or commit or whatever github prefix the commit message with [PATCH] in the subject line, for example: https://patch-diff.githubusercontent.com/raw/boxuk/commit-message-checker/pull/25.patch

It's not a github thing afaik, it's just a standard patch convention. Anyway, I think all we need to do to support this is add PATCH to the list of valid commit types. https://github.com/boxuk/commit-message-checker/blob/master/lib/commit-types.js

from commit-message-checker.

TomSeldon avatar TomSeldon commented on July 1, 2024

That sounds correct. I was meaning to ask @klj613-boxuk what he meant as I wasn't able to find what a commit message for a patch usually looked like.

If it's just [PATCH] some commit message then yeah @jenkoian it would just need adding to that file. Existing unit tests should pick it up (as I think they dynamically create unit tests for each allowed commit message type). Not sure of that though.

from commit-message-checker.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.