Comments (2)
I was about to raise a similar issue, it might be different to what @klj613-boxuk is referring to but here are the details none the less.
When you grab a patch of a PR or commit or whatever github prefix the commit message with [PATCH] in the subject line, for example: https://patch-diff.githubusercontent.com/raw/boxuk/commit-message-checker/pull/25.patch
It's not a github thing afaik, it's just a standard patch convention. Anyway, I think all we need to do to support this is add PATCH
to the list of valid commit types. https://github.com/boxuk/commit-message-checker/blob/master/lib/commit-types.js
from commit-message-checker.
That sounds correct. I was meaning to ask @klj613-boxuk what he meant as I wasn't able to find what a commit message for a patch usually looked like.
If it's just [PATCH] some commit message
then yeah @jenkoian it would just need adding to that file. Existing unit tests should pick it up (as I think they dynamically create unit tests for each allowed commit message type). Not sure of that though.
from commit-message-checker.
Related Issues (13)
- Git commit message hook
- Travis: Should check all commit messages in PR HOT 1
- Spell check commit messages
- Integration with non-Node projects HOT 1
- Add error levels: fail, warn, etc.
- Add Appveyor CI tool HOT 1
- Travis tool sometimes checks wrong commits
- Add config to ignore certain branches
- Improve reporting HOT 1
- Add configurability
- Enforce max line length
- GH web hook integration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from commit-message-checker.