Code Monkey home page Code Monkey logo

Comments (11)

bourgesl avatar bourgesl commented on August 25, 2024

from marlin-renderer.

IceMan81 avatar IceMan81 commented on August 25, 2024

I think what you are saying is that in 0.9.2 there are some changes to the same class that the Jetbrains JRE already hacked?

from marlin-renderer.

bourgesl avatar bourgesl commented on August 25, 2024

In Marlin 0.9.2, I added the following classes included in the optional marlin-0.9.2-Unsafe-sun-java2d.jar:

  • sun.java2d.pipe.RenderQueue
  • sun.java2d.opengl.OGLRenderQueue

JetBrains JRE includes patched RenderQueue (in some releases), so the conflict happens.

Finally, I will propose soon a new pull request to JetBrains JDK8u to upgrade to the latest Marlin renderer.

Depending on the JetBrains JRE you have, it already has either Marlin 0.7.5 or Marlin 0.9.1 (build > 1153.2).

from marlin-renderer.

bourgesl avatar bourgesl commented on August 25, 2024

Finally, I could package these specific RenderQueue classes into another jar file to avoid any conflict in the future.
What do you think ?

from marlin-renderer.

IceMan81 avatar IceMan81 commented on August 25, 2024

Packing them into another jar would help.
Also, I wasn't aware that the Jetbrains JRE had newer versions of marlin-renderer. I use their latest build > 1153.2.

from marlin-renderer.

bourgesl avatar bourgesl commented on August 25, 2024

I am preparing a pull request to Jetbrains JDK8 to upgrade Marlin 0.9.2 so I will not make any change on Marlin releases.
For Jetbrains JRE, do not include marlin-0.9.2-Unsafe-sun-java2d.jar as a workaround.

from marlin-renderer.

IceMan81 avatar IceMan81 commented on August 25, 2024

@bourgesl Thanks. Would you be able to add a note here when the PR gets accepted?

from marlin-renderer.

bourgesl avatar bourgesl commented on August 25, 2024

Pull request merged:
https://github.com/JetBrains/jdk8u_jdk/commits/master

from marlin-renderer.

IceMan81 avatar IceMan81 commented on August 25, 2024

@bourgesl It looks like the problem still persists - the issue is using -Xbootclasspath/p:C:\Programs\marlin\marlin-0.9.2-Unsafe-sun-java2d.jar
I'm using the latest build of intellij-jdk which contains your PR.

from marlin-renderer.

bourgesl avatar bourgesl commented on August 25, 2024

As explained before, Marlin releases provide 2 jars but you must use only marlin-0.9.2-Unsafe.jar with JetBrains JDK8.
Never put marlin-0.9.2-Unsafe-sun-java2d.jar !
or use only jetbrains jdk8 that already provide the Marlin renderer ...

from marlin-renderer.

IceMan81 avatar IceMan81 commented on August 25, 2024

Sorry, for some reason I was under the impression that once marlin 0.9.2 was merged into intellij-Jdk I could continue to use the marlin unsafe sun jar. Thanks for clearing that up.

from marlin-renderer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.