Comments (7)
Oh, looks like this is how Vitter's Algorithm R works. So it is more a question of specification than one of implementation mistake.
from folsom.
Thanks for checking @jlouis. @russelldb might have some thoughts on how this would effect slide_uniform.
from folsom.
I need to look into it too. It seems @Vagabond made this change 2be6249#diff-b7a6cde361f08ae87401c3a98eb116c7 that changes the behaviour of the slide_uniform sample.
from folsom.
Ah, it looks like @Vagabond actually fixes slide_uniform
as it was using Size
not MCnt
as the upper bound for the random number generation (i.e. a fixed, rather than growing value.)
So is the plan to change the sample algorithm?
from folsom.
The code as it works now does the right thing. A uniform histogram samples its reservoir over the entire set of inputs. So if you have a million inputs already, the chance of replacing into the sample reservoir is 1/1000. Which is what you want for the complete overview.
Most of the time however, you want some kind of histogram window in which case the slide_uniform or exdec solutions are more appropriate. So it is really a questions of "what do you want". Not a question of what is correct or wrong.
The reason I opened this was because I was getting unexpected data. But it turns out the data are correct and my expectations of what uniform does was wrong :) You can close this one.
from folsom.
@russelldb I don't think we should change anything. But we should definitely consider explaining what the histogram types does in the README :)
from folsom.
Folsom has moved, please resubmit your issue at https://github.com/folsom-project Thanks!
from folsom.
Related Issues (20)
- A race condition can stop trimming of slide servers HOT 2
- Folsom has moved
- update README.md: application:start(bear) is required before application:start(folsom) HOT 1
- "no function clause" error when calling folsom_vm_metrics:get_system_info() HOT 5
- export lcnt info if available HOT 1
- Grouped metrics HOT 7
- Traffic measurement HOT 3
- A crash of `folsom_metrics_histogram_ets` breaks all `spiral` metrics
- Temporal Counter HOT 3
- forward decay paper has moved HOT 1
- Absolutely zero specs for most things HOT 2
- EWMA vs mean unit of measure inconsistency in meters HOT 2
- crash when deleting ets table. HOT 1
- bear is not listed in .app.src dependencies HOT 5
- Folsom fails to start for host in MongooseIM HOT 7
- Dynamic atoms creation HOT 2
- Tag 0.8.2 HOT 5
- support tags in configuration file HOT 1
- pids and ets ids leaks HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from folsom.