isinstance() and issubclass() may raise a TypeError? about simpleflow HOT 4 CLOSED

Too bad, I don't remember this at all :( But well, raising a TypeError if we don't get an expected type makes sense, doesn't it? So maybe we should just fix the comment.

from simpleflow.

Wrong diagnosis... The problem is not with isinstance (where a TypeError would mean Activity is not a class) but with issubclass which does raise a TypeError if func is anything but a class).

We could do like numpy, which defines

def issubclass_(arg1, arg2):
    try:
        return issubclass(arg1, arg2)
    except TypeError:
        return False

from simpleflow.

Ah OK. Go for that!

from simpleflow.

#96

from simpleflow.