Execute `Workflow.after_run` even if the workflow is not finished about simpleflow HOT 10 CLOSED

Interesting, but sounds confusing :-); what about another method, after_step or something?

from simpleflow.

As the original method is run, I think before_run and after_run are a good choice.

Maybe we should rename current before_run to before_first_run and after_run to after_last_run ?

from simpleflow.

Understood. This would be an API breakage though, so I like your first suggestion better (except it's breaking too... Inspect *_run expected arguments in a deprecation period? Don't care?)

from simpleflow.

Let @jbbarth be the judge 😄

from simpleflow.

before_run should be left as is: it's run on every replay for now ; we could parse the workflow execution history and try to determine if it's the first run (basically: 0 decision task taken so far), but I don't like that idea.

As for after_run, mixed feelings. I don't like the idea of a boolean, I'd better have two different explicit hooks after_run / after_finished. And yes, after_run should be run after any replay even if the workflow raises an ExecutionBlocked (but probably not in other cases if real decision errors occur). But that would break compat' and it's a super bad habit we have. So maybe alias the old after_run to after_finished and introduce a new after_replay or after_step for now? :( or inspect args

from simpleflow.

After thinking of it 5 mins, I like the word "replay" that emphasizes the fact that the code is re-played multiple times.

Proposal:

• introduce before_replay, after_replay, after_finished
• deprecate before_run and alias it to before_replay for now
• deprecate after_run and alias it to after_finished for now

What do you think?

from simpleflow.

👍

from simpleflow.

👍

from simpleflow.

Cool :) @ampelmann I let you do this?

from simpleflow.

It would be a pleasure !

from simpleflow.