Code Monkey home page Code Monkey logo

Comments (4)

frodenas avatar frodenas commented on July 17, 2024 1

I personally like the job namespaced approach, to me it improves readability and ownership of the properties especially when a user needs to create/update/debug a deployment manifest.

OTOH, I recognize it's a pain for the release dev and might be cumbersome when using ie links. But I rather prefer to make this easier to the users than not the release developer.

from prometheus-boshrelease.

cppforlife avatar cppforlife commented on July 17, 2024

I personally like the job namespaced approach, to me it improves readability and ownership of the properties

well... i never know which property is used by which job, because there was no enforcement from bosh. we had/have jobs that were reading other jobs namespace (nats.* for example). hence we've added job level properties (http://bosh.io/docs/manifest-v2.html#instance-groups). for example:

instance_groups:
- name: prometheus
  instances: 1
  jobs:
  - name: prometheus
    properties:
      scrape_interval: something  # <-- weird if namespaced once more
      ...

In the above scenario it's crystal clear (imho) that scrape_interval belongs to prometheus job. Even better Director enforces association and doesnt not allow anyone else to access those properties. Job level properties are not merged with anything as well.

from prometheus-boshrelease.

frodenas avatar frodenas commented on July 17, 2024

Yes, I know job level properties, it solves some use cases, agreed, but I'm not a big fan either. Maybe I'm biased.

from prometheus-boshrelease.

frodenas avatar frodenas commented on July 17, 2024

Closing this. Dealing with manifest files is hard, and I said before, I feel that using the job namespaced approach is better for readability and ownership.

from prometheus-boshrelease.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.