Comments (4)
I believe sdl-image dynamically loads those libs if they're available. The
check in
configure is to ensure Gource will actually work since otherwise sdl-image
can't load
jpegs and pngs.
This appears to stop it from adding them to the LIBS line (by adding an
action-if-found):
#PNG library
AC_CHECK_LIB(png, png_read_info, [ has_libpng=1 ], AC_MSG_ERROR([PNG library
required. Please see README]))
#JPEG library
AC_CHECK_LIB(jpeg, jpeg_read_header, [ has_libjpg=1 ], AC_MSG_ERROR([JPEG
library
required. Please see README]))
Does that fix your warning?
Original comment by [email protected]
on 17 Mar 2010 at 9:45
from gource.
Maybe it would be better if Gource makes some innocuous use of those libraries
so the
warning goes away, but it still linked to libpng and libjpeg so that people
don't
accidentally package Gource without those libraries?
Original comment by [email protected]
on 17 Mar 2010 at 9:52
from gource.
The dynamic linking of sdl-image is not so simple. For example some times ago i
updated jpeg from version 7 to version 8. The output of scanelf -n of the
sdl-image
bins were correct, but trying to use it was resulting in failing to load
libjpeg.so.7
(indeed i update to version 8), so a recompile of sdl-image was needed. But I'm
not
so skilled to understand what happened that time, but all gentoo tools to check
dynamic linking of sdl-image were reporting no problems (and this is strange
they
never failed in my expirience).
Anyway the problem is not the dynamic linking. When you compile sdl-image you
can
forcibly disable the jpeg,png support passing some argument to the configure
script
when compiling sdl-image. I know this normally not happen, but it could in
theory. So
just checking that libpng and libjpeg are installed doesn't assure sdl-image
will
work with jpeg and png. That's why i say that check is useless. The correct way
would
be to check how sdl-image is compiled, but this is not possible at the moment
(and
you may ask upstream if i'm wrong of course).
And finally i have no warning about that by the gentoo package manager, i just
spot
it with my own eyes. Making some "innocuous use of those libraries" is just a
way to
make that check needed (couse you will actually use those libraries in this
way), but
doesn't solves the problem of sdl-image support for jpeg and png.
This problem applies normally only on source based distros or when a user
recompile
sdl-image by himself, since on binary distro sdl-image is compiled with jpeg
and png
support for obvious reason, so just checking that sdl-image is installed will
assure
the presence of jpeg and png libs since they are required by sdl-image in such
a case.
Original comment by [email protected]
on 17 Mar 2010 at 10:41
from gource.
Original comment by [email protected]
on 18 Mar 2010 at 6:37
- Changed state: Accepted
- Added labels: Priority-Low
- Removed labels: Priority-Medium
from gource.
Related Issues (20)
- Feature request: default true stop-at-end for video (was Pause visualization on todays date) HOT 3
- improve physics performance with large number of files/directories HOT 7
- Build instructions not up to date as of Jan 18 2010 HOT 3
- Use system wide font HOT 1
- Failure to parse CVS: date -0600 timezone HOT 3
- Interfacing with FTGL on Fedora 11 HOT 11
- Only white images by PPM export HOT 15
- user images get really small as the tree gets big... HOT 7
- 1920 x 1080 resolution - spheres are not on lines HOT 7
- LINUX - No videocard on server HOT 3
- Linear time HOT 6
- gource fails with segmentation fault when installed with MacPorts on OSX HOT 10
- Allow setting a title HOT 2
- Allow setting a background image HOT 2
- Allow setting a logo image HOT 2
- Gource end before term when --output-ppm-stream is given HOT 11
- Add support for tags HOT 1
- --output-ppm-stream doesn't work anymore HOT 1
- automatic camera rotation for optimal use of screen space HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gource.