Rails 7? about action_mailbox_amazon_ingress HOT 16 CLOSED

@ssunday Such is life ! Thanks for being pragmatic about this and for the continued efforts, it's good to know the work done for the PR can still be put to good use.

I'm away at a conference this week but will try to be responsive to any updates !

from action_mailbox_amazon_ingress.

@bobf Thank you for all your work on it over the years haha!

from action_mailbox_amazon_ingress.

Aha...read the manual. For anyone else who runs across this, here are my learnings:

• SNS has very different formats for that raw message flag, and for different reasons. See the SNS Developer Guide for details, specifically: https://docs.aws.amazon.com/sns/latest/dg/sns-large-payload-raw-message-delivery.html
• SNS will not deliver raw messages if they are over 150K -- such messages will be stored in S3 and you'll need to reach back into S3 to get them.

from action_mailbox_amazon_ingress.

Hi, @davidlbean . Thank you for:

• Giving a thorough description of the problem.
• Trying various combinations of things to solve the issue.
• Figuring out the cause from the docs.
• Doing all of the above by the time I finished work. : )

@chrisortman extended my original Rails PR to handle the situation you've encountered. Although the PR is now nearly 4 years old, @ssunday recently took it upon themselves to try to get the PR merged, so you may find that this is available in mainline Rails relatively soon.

I'm afraid I am highly unlikely to extend this gem at this point but I would welcome a PR, however I think any efforts on this would be better focused on the Rails PR (or migrating the PR to aws-sdk or wherever it is best suited).

Thanks for your interest in this gem !

from action_mailbox_amazon_ingress.

@bobf @davidlbean I haven't e2e tested the PR with my changes to get CI working, so I need to do that (or someone needs to and report that it works) and figure out how to get Rails team to re-review the PR and hopefully merge it 🙏🏻

from action_mailbox_amazon_ingress.

@bobf @davidlbean Okay, as Rails closed the PR so I'll fork this repo and bring in the changes from the Rails PR into it and make a PR with it. 🙏🏻

from action_mailbox_amazon_ingress.

@ssunday If you're willing to start a pull request, we could add this as a feature to aws-sdk-rails.

from action_mailbox_amazon_ingress.

@mullermp I already started working on bringing in the rails-PR changes into this repo's code 😅 and am almost done. Maybe one day I'll do that?

from action_mailbox_amazon_ingress.

Behold #15

from action_mailbox_amazon_ingress.

It's up to you as a suggestion. aws-sdk-rails would give it wider audience and has other AWS - Rails integrations. @bobf mentioned you here rails/rails#39364 (comment)

from action_mailbox_amazon_ingress.

@mullermp Yep, I am aware, and the project I needed this for for also uses aws-sdk-rails. It was just easier to bring it here to get the ball rolling for my project's needs. I don't have any issue about moving it to aws-sdk-rails—it just needs to be done and I don't know if/when I'll be able to.

from action_mailbox_amazon_ingress.

@mullermp Like you can port it over to, or anyone can, my goal was just to get the useful code in a place where projects could easily use it to get their AWS SES inbound connection working 😅

from action_mailbox_amazon_ingress.

@mullermp @bobf I started poking around doing it, but a hurdle I'm experiencing is related to the testing—minitest vs. rspec. I have some tests working/converted, but the request ones are painful and it feels like it'd make more sense to just convert to rspec, but that is also troublesome. I can open a super rough PR with what I have 🤷🏻

from action_mailbox_amazon_ingress.

Go ahead and open a pr to aws-sdk-rails and we can go from there. We prefer minitest for the rails part (I think it was simpler at the time?) although we use rspec in other products. We're not opposed to switching over.

from action_mailbox_amazon_ingress.

@mullermp Got it, I'll get a PR up.

from action_mailbox_amazon_ingress.

aws/aws-sdk-rails#127

from action_mailbox_amazon_ingress.