Hawkeye username interpretation not strict enough about hawkreloaded HOT 13 CLOSED

Uhh not sure about this one. I can't remember the last time i fully typed out someones name :P

from hawkreloaded.

the problem appears with short generic names like in the following sitatuation (wheres names are just an example):

Two players built on the server: Griefer and NotAGriefer
Griefer went crazy and ruined the entire town, while NotAGriefer obeyed the rules and didn't ruin anything.
If I were to type /ha rollback p:Griefer I will actually rollback NotAGriefer as well because 'Griefer' is in its name.

It also is a major problem when you have same variations in usernames like Legolas, LegolasTheArcher, Legol, Legolos, ...

If you would roll back the player Legol, it will actually rollback 3 other players along with it.

Basically I discovered the problem after some of the builds went missing of our users. I discovered that I could roll myself (and others as well) with just typing /ha rollback p:q
This made me (q220) rollback, and it would have definatly rolled back a player called 'q', and what I fear is that it highly likely will rollback every username with the letter q in it as well :\

from hawkreloaded.

Oh i didn't know you globally rolledback. Uhh i MIGHT add something like p:"bob7l" which allows the name to be strict. For the time being, do something like /he rollback p:griefer,!notgriefer

from hawkreloaded.

yeah, it was a global rollback. My suggestion is only to be strict to the name when it comes to rollbacks. Like in your example, if i'd want to rollback 'bob7l' only rollback 'bob7l' and have hawkeye not rollback 'minecraftbob7l' or 'bob7lplaysminecraft' or other variations with bob7l in them :p

from hawkreloaded.

Alright i added it to the latest build. 'bob7l' & "bob7l" looked pretty ugly in minecraft text so instead i changed it to *

Example: /he rollback p:*bob7l

from hawkreloaded.

Does that mean that using the wildcard * will make rollbacks for every user whose usernames ends on bob7l, or that it will only rollback the username bob7l?

from hawkreloaded.

It will ONLY rollback the user named bob7l, and ignore everyone else.

from hawkreloaded.

Wouldn't it be better to have it the other way around? That /ha rollback:bob7 would only rollback the player bob7? And have * act like a wildcard? /ha rollback p:bob7 or bob7 would make all usernames rollback who end on bob7 or begin with bob7

from hawkreloaded.

Well almost everyone i know who uses hawkeye uses it directly for the short usernames as they don't like to fully type it out so i like to please the majority. Plus to be honest, i doubt 99/100 hawkeye users even know about the ! flags lol.

from hawkreloaded.

I personally think making the * act as a wildcard would be the best option. Bob if you want I can work on this when I get time.

from hawkreloaded.

Yeah bob7l, I understand how useful it is for short usernames. I run a server which sees a lot of players, and we really use hawkeye on a daily basis to control the damage around. Its only after like years of using Hawkeye that i stumbled upon the issue (after a few legitimate buildings went missing)

The shortname functionality is very handy to have when doing searches, I wouldn't want to see it go at all as well. The only thing that I wanted to bring up was the 'lack of control' you could have in rare cases, where you (and without you knowing) can roll back multiple users because the name isn't used strict enough when doing rollbacks. If hawkeye is setup to remove rolled back entries, you can't really restore or undo the operation anymore when you discovered it too late. Anyway, thanks for listening and considering this :)

from hawkreloaded.

This is old as hell, but still an active issue.

What i'm thinking about doing is checking the hashmap for the player-name. If the hashmap does not contain the name, attempt to find a name LIKE the entered name.

from hawkreloaded.

Finally fixed this issue for you. I somehow managed to misinterpret you throughout this whole conversation xD...

I also optimized the whole lookup process, so there's that.

07c714b

from hawkreloaded.