OpenSSL Not Detected about facil.io HOT 4 OPEN

Sure thing! I realized after I commented that I missed the line below, so make sure you grab the version now (2 lines changed) :)

from facil.io.

Hi @tekktonic ,

Thank you for opening this issue and for your interest win facil.io.

The TLS/SSL verification tests attempts to compile and run a small piece of C code in the make file. If you have OpenSSL 1.1.x and this fails that the most likely explanation is that OpenSSL is missing from either LIBRARY_PATH (library files) or CPATH (header / include files).

If you use pkg-config, these locations *should be added automatically by the makefile - but I don't have pkg-config, so I don't remember testing this codepath (it's there for my linux machine, but I think OpenSSL is in the LIBRARY_PATH on that one)...

... You can review the final CFLAGS and LINKER_FLAGS values using make vars.

If this doesn't help, you can get a more detailed error message by erasing the error print redirection in the makefile's test functions by deleting the 2> /dev/null on lines 199-200 of the makefile.

Good luck! And if you discover anything that would be fun to incorporate, please let me know.

Kindly,
Boaz.

from facil.io.

Well that was a pretty quick find. gcc can be picky about the order of ldflags. This diff fixes it:

diff --git a/makefile b/makefile
index 3fbcfcf4..ea1cdac3 100644
--- a/makefile
+++ b/makefile
@@ -196,8 +196,8 @@ OBJS_DEPENDENCY:=$(LIB_OBJS:.o=.d) $(MAIN_OBJS:.o=.d)
 # TRY_COMPILE_AND_RUN returns the program's shell code as string.
 #############################################################################
 
-TRY_COMPILE=$(shell printf $(1) | $(CC) $(INCLUDE_STR) $(LDFLAGS) $(2) -xc -o /dev/null - >> /dev/null 2> /dev/null ; echo $$? 2> /dev/null)
-TRY_COMPILE_AND_RUN=$(shell printf $(1) | $(CC) $(2) -xc -o ./___fio_tmp_test_ - 2> /dev/null ; ./___fio_tmp_test_ >> /dev/null 2> /dev/null; echo $$?; rm ./___fio_tmp_test_ 2> /dev/null)
+TRY_COMPILE=$(shell printf $(1) | $(CC) $(INCLUDE_STR) -xc -o /dev/null - $(2) $(LDFLAGS) >> /dev/null 2> /dev/null ; echo $$? 2> /dev/null)
+TRY_COMPILE_AND_RUN=$(shell printf $(1) | $(CC) -xc -o ./___fio_tmp_test_ - $(2) 2> /dev/null ; ./___fio_tmp_test_ >> /dev/null 2> /dev/null; echo $$?; rm ./___fio_tmp_test_ 2> /dev/null)
 EMPTY:=
 
 #############################################################################

I can open it as a pr if you prefer, I just didn't want to go through the trouble of forking, applying the change on my fork, and opening it when the diff is trivial.

from facil.io.

Thanks! I'll add this in :)

from facil.io.