Add rule for test cases being too similar about robotframework-lint HOT 2 CLOSED

This sounds difficult to do right, plus I think it's sometimes reasonable
to have test cases that are identical except for the final validation step.

There is a school of thought that a test case should test only one thing.
So, for example, I may have a test for a file parser that parses the file
and then verifies that the return code is zero. I might have another test
that also parses the file and then verifies that it doesn't print anything
to stdout. These two tests would be identical except for the name,
documentation string, and final keyword. Though, maybe because of that your
rule wouldn't be triggered?

Testing for duplicate documentation and duplicate names might be the better
way to go. I know we have the problem that people will cut and pasted a
whole test case, modify the final verification, but forget to update the
documentation.

On Thu, Dec 11, 2014 at 4:45 PM, Guy Kisel [email protected] wrote:

I was thinking it would be nice to have a rule that warns about code
duplication, or about the potential to pull reused code out into a separate
keyword.

I've made an initial attempt at it, but I was wondering if anyone else
thinks this seems like something worth doing, or if it would just raise too
many false positives to be useful.

guykisel/robotframework-lint@7412f5c
guykisel@7412f5c

—
Reply to this email directly or view it on GitHub
#16.

from robotframework-lint.

That's a good point. Looking for duplicate documentation seems reasonable, and it would be pretty easy to adapt my code to do that instead. All I'm really doing is using difflib to compute a similarity ratio.

from robotframework-lint.