Comments (14)
Thanks a lot @bmcfee
The package is now ready.
I should hopefully go into the main archive in a a couple of weeks
from resampy.
Dear @bmcfee, I'm currently working on the packaging of resampy for debian (hope you don't mind).
According to the debian policy, It would be important to have the possibility to re-generate the data file containing the filter(s) during the build process.
For this reason having this issue closed would be the ideal solution.
Do you plan to implement is in the near future? Do you have already in mind a date for the v0.3.0 release?
If this is the case I will wait the next release before submitting the upload request.
Otherwise I will need to figure out some workaround that allows me to be compliant with the debian policy.
from resampy.
I'm currently working on the packaging of resampy for debian (hope you don't mind).
Not at all - thanks for putting in the effort!
Do you plan to implement is in the near future? Do you have already in mind a date for the v0.3.0 release?
If this is the case I will wait the next release before submitting the upload request.
Otherwise I will need to figure out some workaround that allows me to be compliant with the debian policy.
I think so, yes. I took a bit of time this afternoon to prototype a newer version of the parameter solver using optuna. (The previous version used https://github.com/craffel/simple_spearmint/ which was never properly packaged.) As it currently stands, it reliably produces filter parameters that are pretty close to what the old version did. I want to experiment with it a bit more to see if I can bring the noise down following the thread in #75, but I think this will be doable for the 0.3 release.
from resampy.
Thanks for your quick reply.
Unfortunately optuna is not available in debian currently, so I'm not sure that the new script would solve mi problem.
Would it be possible to have a copy of the data saved in txt format in the repo?
Probably this could help.
from resampy.
Unfortunately optuna is not available in debian currently, so I'm not sure that the new script would solve mi problem.
Is that strictly necessary though? It wouldn't be a run-time dependency.
Would it be possible to have a copy of the data saved in txt format in the repo?
Is .npz not sufficient for this?
from resampy.
Unfortunately optuna is not available in debian currently, so I'm not sure that the new script would solve mi problem.
Is that strictly necessary though? It wouldn't be a run-time dependency.
The idea is that the debian package should be re-build entirely form sources in a debian environment and without any access to the interned. Not having opuna in debian is blocking in this sense.
Of course one could also create a debian package for optuna but this would require more effort.
Would it be possible to have a copy of the data saved in txt format in the repo?
Is .npz not sufficient for this?
I fear it is not.
I will check again the policy and discuss with debian developers.
from resampy.
The idea is that the debian package should be re-build entirely form sources in a debian environment and without any access to the interned.
I think we still satisfy that requirement if the data is provided. The packaged filter coefficients are just a cache of something you could compute directly with an explicit parametrization. While I agree that it would be great in principle to have this all end-to-end, it seems way overkill IMO. They wouldn't require this for something like icons or audio excerpts, right? What makes this any different?
Is .npz not sufficient for this?
I fear it is not. I will check again the policy and discuss with debian developers.
That also seems weird to me. It's an open format, and generally preferably to a text-based encoding (which may be lossy via float<->decimal conversion).
from resampy.
The idea is that the debian package should be re-build entirely form sources in a debian environment and without any access to the interned.
I think we still satisfy that requirement if the data is provided. The packaged filter coefficients are just a cache of something you could compute directly with an explicit parametrization. While I agree that it would be great in principle to have this all end-to-end, it seems way overkill IMO. They wouldn't require this for something like icons or audio excerpts, right? What makes this any different?
Sorry, just for me to understand, Is it something that I can compute using the resampy.filters.sinc_window
function?
If so, probably it is just a matter of documenting the parameters somewhere e.g. a dedicated README in the data folder.
from resampy.
Sorry, just for me to understand, Is it something that I can compute using the
resampy.filters.sinc_window
function?
Basically yes. "kaiser_best" and "kaiser_fast" are cached versions of filters constructed by sinc_window
. The concern of this issue is the code which selects which parametrization (beta, rolloff, maybe other parameters) should be cached, and this only needs to happen once (in 2016
from resampy.
Sorry, just for me to understand, Is it something that I can compute using the resampy.filters.sinc_window function?
Basically yes. "kaiser_best" and "kaiser_fast" are cached versions of filters constructed by sinc_window. The concern of this issue is the code which selects which parametrization (beta, rolloff, maybe other parameters) should be cached, and this only needs to happen once (in 2016 grimacing). There is no runtime dependency, or even build-time dependency on this parameter optimization whatsoever.
OK, do you have parameters used to generate "kaiser_best" and "kaiser_fast" in resampy v0.2.2?
If my understanding is correct the parameters documented in #98 are the new ones, correct?
Having the parameters would completely solve my problem with the debian packaging, because I can generate the binary files during the build process with a very simple script.
from resampy.
OK, do you have parameters used to generate "kaiser_best" and "kaiser_fast" in resampy v0.2.2?
Sorry I have just realized that the parameters are already documented in the (current) docstring.
Probably only the precision is missing, but I can retrieve it anyway.
from resampy.
Probably only the precision is missing, but I can retrieve it anyway.
Yeah, sorry for that - the open pr #98 documents this more fully. The precision values are stored in the data files though, so all the information is there.
from resampy.
Very cool - thanks!
I'll also plan to have the 0.3.0 release done up soon, and the upgrade process should be pretty easy.
from resampy.
yes, after the first upload in the debian archive I should be able to perform the update to new versions very quickly
from resampy.
Related Issues (20)
- v0.3.0 produces other results than v0.2.2 HOT 3
- Resampy 0.3.0 is slow for multi-dimensional input HOT 5
- Issues with Numba 0.55.2 HOT 4
- Resampy 0.3.1 slows down other libraries HOT 43
- Use parallel=True by default can be problematic in multiprocessing applications HOT 8
- Bringing import time back down
- Edge Case, rounding error in length calculation HOT 3
- Missing argument in guvectorize decorator ? HOT 2
- Quality issues? HOT 5
- resampling to the same hz HOT 1
- Incompatible with latest numba HOT 3
- Best quality resampling?
- PyPI status HOT 2
- Add linting CI
- Add pypi packaging workflow HOT 1
- Drop legacy python support
- Fix documentation builds HOT 1
- Update README badges
- Cache filters on load
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from resampy.