Code Monkey home page Code Monkey logo

Comments (10)

djc avatar djc commented on July 18, 2024 1

I'm not sure what you mean? We don't want to pin dependencies for MSRV reasons -- we just keep the versions in Cargo.lock low enough that CI can still pass.

from trust-dns.

djc avatar djc commented on July 18, 2024

I noticed that we now also depend on h3, so I started a PR for upgrading h3-quinn to Quinn 0.11 already.

from trust-dns.

djc avatar djc commented on July 18, 2024

Draft PR for the TLS upates in #2217.

from trust-dns.

AaronKutch avatar AaronKutch commented on July 18, 2024

the smallvec version and some other utility crates are quite old, could they be updated if it doesn't conflict with MSRV?

from trust-dns.

djc avatar djc commented on July 18, 2024

@AaronKutch they should! If you want to help out with that, it would be greatly appreciated!

from trust-dns.

AaronKutch avatar AaronKutch commented on July 18, 2024

Could I update several crates to only specify the minor version instead of patch version, when their repos indicate stricter MSRV guarantees (the last time a lot of them had their MSRV updated, it was to 1.56 because of syn 2)? E.x. most of the things that aren't async runtimes and ssl related stuff.

from trust-dns.

AaronKutch avatar AaronKutch commented on July 18, 2024

In the workspace .toml, there are dependencies that specify down to the patch version, is that what pinning versions too specifically would mean? In most crates, the MSRV is only updated across minor version changes at most, with a few exceptions like the backtrace crate.

from trust-dns.

djc avatar djc commented on July 18, 2024

I think you're misunderstanding how Cargo manifest dependency specifications work. In Cargo, dependencies without an explicit operator work like they have an implicit ^ operator, so any semver-compatible newer version can be used. Since there's not currently a smallvec 2.x version, our dependency specification is already compatible with the newest version of smallvec (and if you look at Cargo.lock you can see that we currently use 1.13.2 for testing).

So as far as I can tell from a quick glance, the only dependency where we're actually lagging is prefix-trie, which has recently had a 0.4.0 (and 0.4.1) release which we should pick up.

from trust-dns.

AaronKutch avatar AaronKutch commented on July 18, 2024

I think I have been misunderstanding how cargo updates versions this whole time. I always thought the way it worked was that if there were an array of x.y.z versions and "x" was specified, then cargo was allowed to update the y and z. If "x.y" was specified, then it could only update the z. Finally, if "x.y.z" were specified then it would fix it to that exact version. I did not realize it could jump to just any SemVer compatible version, I thought that was what the modifiers like >= did. It seems like ~ does what I expected, I don't know how I never noticed this. The only crates that can actually be updated right now by changing the .toml is h3*, prefix-trie, quinn, and rustls.

from trust-dns.

djc avatar djc commented on July 18, 2024

Most of those are taken care of in #2217, though.

from trust-dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.