Comments (12)
picca
commented on August 25, 2024
1
Hello, maybe the best would be contact the maintainer of c-blosc in Debian, and request an upload of the beta version of the currently beta version into experimental.
This wait it will be build on all our architectures, and we could have a nice visibility of the portability of the code.
https://tracker.debian.org/pkg/c-blosc
Cheers
Fred
from c-blosc2.
kif
commented on August 25, 2024
Apparently it has to be C11, not C99 ... it compiles a bit further
from c-blosc2.
kif
commented on August 25, 2024
The auto-guess of the version of the glibc apparently is the root of the bug ...
from c-blosc2.
FrancescAlted
commented on August 25, 2024
So are you finally able to compile blosc2 in your pine64 box?
from c-blosc2.
kif
commented on August 25, 2024
On Thu, 12 Sep 2019 11:40:24 -0700 Francesc Alted ***@***.***> wrote:
So are you finally able to compile blosc2 in your pine64 box?
I had to modify quite a bit the source code... enforcing the C11 spec was not enough.
Instead, using a "#define __USE_POSIX199309" before including time.h helped.
In time.h there is:
#if defined __USE_POSIX199309 || defined __USE_ISOC11
# include <bits/types/struct_timespec.h>
#endif
I have no idea on how to fix this "properly" as all computers were
running the same operating system. Oddities of the arm64 ?
I did some benchmarking of filters, focusing of the "shuffle" and
"bitshuffle", on different architectures in order to check the
effectiveness of SIMD implementations. x86_64 (SSE2 & AVX2) and arm64
(NEON) for now and hopefully ppc64le (ALTIVEC) soon, correlated with
the bloc size and the last level cache size of the processor.
Quick conclusion are that SSE2 helps a lot, AVX2 is not so much faster
if at all. For NEON it is even more complicated: the results are
extremely dependent on the cache size. I can share them with you if you
are interested.
Just a comment on the API which is not exposed to the public:
While the API looks consistent for shuffle, I think it is less
consistent for bitshuffle. For example neon implementation is called:
bitshuffle_neon(...) which is rather natural, but the generic, sse2 and avx2
implementations are called: bshuf_trans_bit_elem_scal(...) _sse2 and _avx2.
Is there are reason for not keeping the "_generic" and the same base
for the function name ? It would be perfect if the signatures could be
similar but the bitshuffle takes an extra buffer argument. So maybe it
is not worth changing this.
Cheers,
Jerome
from c-blosc2.
FrancescAlted
commented on August 25, 2024
Ha, it is curious because I don't remeber having this problems with struct_timespec.h in Ubuntu 16.04/18.04 for Raspberry. Maybe the issue is just in Debian? Very strange...
Regarding bshuf_trans_bit_elem_scal() name inconsistencies, yeah, currently that is quite a mess of naming, but fortunately, this is not part of the public API, so if you want to put some order in this naming jungle, you are welcome.
from c-blosc2.
kif
commented on August 25, 2024
Maybe it is debian ... I just got access (again) to the power9 with debian 10 and it is the same issue. I'll check twice on amd64 and arm32 but surprisingly it works there without complain.
About the unconsistency of the private API, I noticed it only because I benchmarked those functions.
from c-blosc2.
kif
commented on August 25, 2024
Coming back on this "failed to build from scratch", I tested on the power9 and arm64:
#include <time.h>
#include <stdio.h>
int main()
{
printf("Posix is %d",__USE_POSIX199309);
return 0;
}
And guess what? both are properly defined. May the error be in the cmake default options ?
from c-blosc2.
kif
commented on August 25, 2024
I tested if "features.h" was properly included or not and apparently it was. The error is somewhere else.
@picca this issue looks to be specific to debian10, any idea ?
from c-blosc2.
kif
commented on August 25, 2024
I just "debootstrapped" a ubuntu 18.04 system (gcc7) on ppc64le and the issue is apparently the same.
It should not be a debian issue. I will git-bisect.
from c-blosc2.
kif
commented on August 25, 2024
It compiles with clang7 but neither with gcc7 nor gcc8. The problem is apparently in the expand of the macros. It looks like std=c99 is not having effect, or at least not as much as on amd64
from c-blosc2.
kif
commented on August 25, 2024
PR under creation
from c-blosc2.
Related Issues (20)
- Public b2nd.h includes blosc-private.h, which is not installed by CMake HOT 2
- SOVERSION bump HOT 3
- Release package has a different checksum from 3 weeks ago HOT 4
- Why no chunk skipping in sparse frame? HOT 1
- Invalid instruction at 0x7f89795d34c4 in shuffle HOT 3
- The vulnerability is a memory leak bug located at line 565 of the file /c-blosc2/blosc/schunk.c HOT 1
- Altivec option is misleading, it should be VSX; also, why only ppc64le, but not ppc64 (for supported CPUs)? HOT 8
- `LICENSES/FASTLZ.txt` HOT 2
- ImportError: libblosc2.so.2: cannot open shared object file: No such file or directory HOT 1
- Feature Request: Opt ouf of `blosc_get_cpu_features` HOT 3
- Implicit declaration of function ‘malloc’ on on ppc64el HOT 1
- Failure compiling on windows with Intel OneAPI HOT 2
- blosc2_schunk_open_udio calls stat
- Incorrect case for windows.h in blosc2-stdio.h
- Tracing macros HOT 1
- `shuffle.c` is compiled with `-mavx512*` which results in `SIGILL` on lower CPUs HOT 5
- Add .b2nd as officially supported file extension to the file format specification or use .b2frame otherwise HOT 1
- Should there be a function to create an NDIM array initialised with BLOSC2_SPECIAL_NAN? HOT 3
- Feature request: Add support for ALP (Adaptive Lossless floating-Point Compression)
- Failure building on linux with _xgetbv HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from c-blosc2.