Code Monkey home page Code Monkey logo

Comments (3)

georgantas avatar georgantas commented on July 17, 2024 1

Makes sense, I forgot the Jade asks the user to confirm the fee 🤦‍♂️ Thank you :)

from jade.

georgantas avatar georgantas commented on July 17, 2024

Actually, based on this comment, it seems SingleSig/regular MultiSig change does not need to be confirmed by the user (I was checking MultiSig Shield change).

In that case, can a malicious computer omit the change address completely causing the user to burn the change they should have gotten?

from jade.

JamieDriver avatar JamieDriver commented on July 17, 2024

At the moment, no - it does not verify or mandate the presence of a change output. (It is possible [albeit unlikely] that there really is no change.)

So Jade will ask the user to confirm every output - other than those verified as change.
It then, as a final step before signing, asks the user to confirm the fee - this is calculated on the hardware as sum(inputs) - sum(outputs) - so while your suggested attack is possible the user would have to confirm a suspiciously large fee.

I suppose if there is no change output we could add a warning message on that final 'confirm fee' screen - but then that could be confounded by the malicious app adding a very small change output ...

from jade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.