feat: blockful custom erc20 as the mock contract about swaplace-contracts HOT 6 CLOSED

Hello! I am interested in this task. I have some experience in writing tests using typescript and chai for smart contracts.
@0xneves

from swaplace-contracts.

Well go for it, can't barely wait to see the PR @RafaDSan 👍

from swaplace-contracts.

Hey @RafaDSan , how is the task going? Do you need anything to help you with?

from swaplace-contracts.

Hey @0xneves, if this task isn't started, I'm interested to get

from swaplace-contracts.

@0xneves I've added some new tests to the TestMockContracts.test.ts file but I am having some problems importing the ERC20 code.
Here is what I am doing:

1. Copied the erc20 contract of blockful and pasted in the MockERC20.sol
2. Changed the line abstract contract ERC20 is IERC20, IERC20Permit, IERC20Errors for and removed the abstract
3. Added the following files to the interfaces directory: IERC20.SOL, IERC20Errors.sol, IERC20Permit.sol
4. Run the command npx hardhat test and receive the following error Error: missing argument: in Contract constructor (count=0, expectedCount=2, code=MISSING_ARGUMENT, version=contracts/5.7.0) which I am trying to figure it out rn.

from swaplace-contracts.

Hello @RafaDSan, I think you are misunderstanding the behavior of this task, let me summarize...

The ERC20 in blockful-contracts is abstract because it is an implementation, inside the 'contracts/test' folder you can find the token implementing the ERC.

In essence, the task is:

• Get the ERC20 related contracts from the blockful-contracts repo and place them in the MockERC20 of Swaplace.
• Copy the tests in the 'blockful-contracts/tests' folder and place them in the Swaplace tests folder.

The error you were getting was from changing the contract from abstract to non-abstract. Remember you should not change any aspects of the ERC20 contract, and only change the import of the MockERC20 from OpenZeppelin to the local contracts imported from 'blockful-contracts'.

from swaplace-contracts.