Comments (5)
In this case, the relation
on https://github.com/blittle/backbone-nested-models/blob/master/backbone-nested-models.js#L30 is undefined
, and the default value (model instance) is taken as the source to instantiate the attribute. That results to the wrong value - new Author(new Author)
.
from backbone-nested-models.
PR submitted, pls review and merge if ok. Close this issue.
from backbone-nested-models.
I've to reopen the issue, because the fix does not work properly when working with events.
With the above fix, the single instance in the defaults
may be shared in a collection of this model, that will cause the below event binding issue:
var Books = Backbone.Collection.extend({
model: Book,
initialize: function() {
this.model.get('author').on('change', ...); // the author instance may be just the single default one
// all books in the collection are listening to change event on **one** instance,
// but in fact we may expect each book to just listen to its own author change
}
});
I will send out another PR to fix this issue and also the collection case.
from backbone-nested-models.
PR #32 submitted to fix the new issue.
from backbone-nested-models.
Thx for the pr!
from backbone-nested-models.
Related Issues (14)
- Design philosophy, differences between existing solutions? HOT 2
- Same name? HOT 2
- url option is passed down to all sub-models/collections
- Options not passed along when performing CRUD actions
- Multiple level nesting HOT 3
- events not firing on nested children
- Can't install via NPM + UMD wrapper is broken HOT 7
- test
- get of relation doesn't work in initialize function HOT 4
- bower install backbone-nested-models installs a different package HOT 2
- toJSON should call nested collection/model toJSON methods HOT 1
- Issues with events for nested Models/Collections HOT 4
- Reference to parent should be available at initialisation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backbone-nested-models.