Comments (7)
That's an interesting one. Will take a look at what may be provoking the crash.
from blink.
I thought people won't type weird things and closed #1900. I was wrong.
![Screenshot 2024-03-20](https://private-user-images.githubusercontent.com/14329097/314503540-e935457e-ab3a-4690-90a3-d3a0d4206121.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2OTU0NzYsIm5iZiI6MTcyMTY5NTE3NiwicGF0aCI6Ii8xNDMyOTA5Ny8zMTQ1MDM1NDAtZTkzNTQ1N2UtYWIzYS00NjkwLTkwYTMtZDNhMGQ0MjA2MTIxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDAwMzkzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRhODJiMmQ1YjdkNWRjYjJmYjExYzBiZjgzZmRhNzA4OGNjYWVkNjk2OTQ1ZTc4MWYxZTRiZTdkYjRiZDA5YjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-CoMq6smbSW00F3LIel5QYF1Rqr-xMY4Ns6U0jxKgwI)
Edit: #1900 is not actually relevant, because this is valid UTF-8. The correspondence comes from "weird things typed".
from blink.
Well I did not really input it intentionally, it just happened ;-). Still would be good if that didn't cause a hard crash
from blink.
No worries. I didn't mean to be harsh about this. I hold the same opinion that a crash or freeze should not happen.
This crash happens inside ios_system and I can reproduce it in a-shell too. I'm having a hard time getting Address Sanitizer to work inside ios_system, but there is some progress.
from blink.
Passing the string 1E 00
(Ctrl-^) to getLastCharacterOfArgument()
returns an invalid pointer 0x1
. This needs to be fixed upstream.
![Screenshot 2024-03-21](https://private-user-images.githubusercontent.com/14329097/314574728-cfa0d0bf-cf5a-449a-ae59-26cd50a87912.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2OTU0NzYsIm5iZiI6MTcyMTY5NTE3NiwicGF0aCI6Ii8xNDMyOTA5Ny8zMTQ1NzQ3MjgtY2ZhMGQwYmYtY2Y1YS00NDlhLWFlNTktMjZjZDUwYTg3OTEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDAwMzkzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJmODA4OWYyYjQzZDJiYTJmYWU1ZmRkMjQzZGIwMWZkNmI1ZTBhY2VmYWU5ZTIyYTI5OWY0N2M5ZTk1OTMzYTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.eMteUc-2ABFG5BdFSGsMmlhxyuKKuQquK39oI7pRKcU)
P.S. Address Sanitizer was not needed for this.
from blink.
@carloscabanero I have a patch for it. It's very unfortunate that ios_system uses ^^
as its internal Record Separator for arguments with both '
and "
. The internal ^^
always comes in pairs, except when you put one in the input ;)
diff --git a/ios_system.m b/ios_system.m
index 21e9eeb..87a498b 100644
--- a/ios_system.m
+++ b/ios_system.m
@@ -2459,6 +2459,7 @@ static char* getLastCharacterOfArgument(const char* argument) {
return NULL;
} else if (argument[0] == recordSeparator) {
char* endquote = strchr(argument + 1, recordSeparator);
+ if (endquote == NULL) return NULL; // be safe
return endquote + 1;
}
// TODO: the last character of the argument could also be '<' or '>' (vim does that, with no space after file name)
from blink.
Done 17.3.0 . Thanks for the help
from blink.
Related Issues (20)
- Missing tab completion for `mosh1` HOT 3
- Resizing text often hangs HOT 1
- Curl hard crashes Blink in 17.3.0 (871) HOT 2
- Non-responsive black window after moving tab to new window HOT 3
- Mosh connection issues HOT 5
- Using cd .. to change back to home directory fails HOT 1
- Support mosh-server verbose parameters
- No way to disable gestures HOT 2
- ProxyJump doesn't work when jump server has underscore in name HOT 4
- Support new M4 iPad display sizes HOT 23
- vscode cannot rename symbol
- On TF: Missing keystrokes on SSH
- Can't connect to host pneuma._peer.internal with weird SSH error HOT 2
- Cannot import 1Password keys. HOT 1
- Importing keys from clipboard or file were not displaying errors
- Characters being drawned with incorrect offset on lines with emoji characters
- When you use the floating onscreen keyboard on an ipad screen is sized incorrectly HOT 1
- Suggest default key name if the key doesn't exist previously.
- Screen redraw on emacsclient off by one?
- Full screen mirroring
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blink.