M files fail if you don't have a docstring about oct2py HOT 8 CLOSED

One more thing about this. If you have a syntax error in your code, when help(my_function) is called by _get_doc you get this same obscure error about the command not being available. The _get_doc call is failing on the help command but because there is a syntax error.

from oct2py.

Another good catch. I have the flu, so it may be a little while before I get to it.

from oct2py.

Sorry, hope you feel better.

I tried to figure it out but I wasn't sure what elif line == '\x15' actually is checking for.

from oct2py.

I wrap the commands in a try/catch block in Octave. If all goes well,
Octave prints char(3), which is '\x03'. If an error is thrown, Octave
prints char(21), which is '\x15', which is what I am checking for in that
line. Basically, I need to rethink the way I check for the existence of a
function, and not require it to have a docstring.

On Wed, Dec 18, 2013 at 9:58 PM, Jason Moore [email protected]:

Sorry, hope you feel better.

I tried to figure it out but I wasn't sure what elif line == '\x15'actually is checking for.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-30903507
.

from oct2py.

That logic is in Oct2Py.__getattr__, which calls Oct2Py._get_doc for
any unknown attribute lookup.

On Wed, Dec 18, 2013 at 10:10 PM, Steven Silvester <
[email protected]> wrote:

I wrap the commands in a try/catch block in Octave. If all goes well,
Octave prints char(3), which is '\x03'. If an error is thrown, Octave
prints char(21), which is '\x15', which is what I am checking for in that
line. Basically, I need to rethink the way I check for the existence of a
function, and not require it to have a docstring.

On Wed, Dec 18, 2013 at 9:58 PM, Jason Moore [email protected]:

Sorry, hope you feel better.

I tried to figure it out but I wasn't sure what elif line == '\x15'actually is checking for.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-30903507
.

from oct2py.

Here's what should happen now (in the dev branch):

If the function exists and has a docstring, we use that. If it exists and does not have a docstring, we use a blurb about the function and the function declaration (assuming it is on the top line of the file). Example:

temp_oct2py_func is the user-defined function defined from: C:\Users\silvester\Documents\Python Scripts\temp_oct2py_func.m

function [outp] = temp_oct2py_func(inp)

If it does not exist, we raise an error similar to:

oct2py.utils.Oct2PyError: Function "temp3" does not exist on the Octave session path

Unfortunately, if the script has a syntax error, Octave closes the connection (but we raise an error with a notification). I cannot figure out how to avoid that behavior.

from oct2py.

Looks good.

Maybe on the closed connection error, you could suggest to the user to ensure the m file works from Octave.

from oct2py.

I'll add the line If using an m-file script, make sure it runs in Octave to the error message. Also, I added the ability to use pexpect on non-Windows platforms, which prevents Octave from closing the connection when there is a Syntax Error (since it registers as a tty connection). Thanks again!

from oct2py.