Comments (2)
"Tests to make sure we're excavating query parameters"
This exists, there are a number of tests with the prefix TestExcavateParameterExtraction
that cover this.
from bbot.
As far as the first point, we've discussed this some offline, but i'll summarize a few points for consideration:
- There is very little overlap, really only one YARA rule that crosses over between two. This is because most parameters are extracted in a way that doesn't touch the actual URL at all, for example in forms, in jquery calls, etc.
- Parameter extraction has a lot more complexity, and also isn't on by default. This enables us to skip this complexity when we aren't doing any thing with
WEB_PARAMETER
. - It is extremely likely we'd actually add overall complexity by trying to merge the functionality.
(As simple as possible URL extraction + As simple as possible Parameter extraction) < Very Complex Combined Extraction - The YARA rules are all compiled. This means the additional overhead by adding one YARA rule is very small, even if it is doing a very similar thing in one or two cases. The process of compilation minimizes this overhead.
- Clear logical separation. Since URLs go to completely different event types than parameters, and have very different rules, separating their post-processing logic will make everything significantly more maintainable.
- Slowed URL processing. URLs are handled more frequently, and adding parameter logic there means every URL extraction is going to take longer.
from bbot.
Related Issues (20)
- Add module to inspect MTA-STS policies
- Add module to inspect SMTP TLS-RPT policy
- Add module to inspect BIMI selector TXT records
- Add module to inspect DMARC policies
- Occasional CPU Spikes in 2.0 HOT 1
- Excavate enhancement handle `RAW_TEXT` events HOT 2
- Repeated DNS Discovery Chain HOT 4
- Provide ability to run tests against a single module via bbot/test/run_tests.sh script
- Add consistent method to identify service record type names is needed
- Error formatting event context HOT 1
- Enhance Trufflehog module to finds Deleted & Private Commits on GitHub HOT 1
- Enhance Postman module to export workspaces as `CODE_REPOSITORY` events HOT 1
- Confidence Rating on Events HOT 1
- Make dnsbrute modules active HOT 1
- Unstructured error: NLTK Resource "punkt_tab" not found. HOT 2
- Modules to download code repos are missing from default code-enum preset HOT 1
- Wayback Handle Event HOT 1
- Support Usernames as Targets HOT 1
- Recursion bugs still present in iis_shortnames
- BBOT v1.x vs v2.x SIEM Friendly JSON HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bbot.