Code Monkey home page Code Monkey logo

Comments (5)

TheTechromancer avatar TheTechromancer commented on July 19, 2024 1

Looks good.

The majority of the work will be in fixing the tests and making sure everything works as intended.

from bbot.

domwhewell-sage avatar domwhewell-sage commented on July 19, 2024

Just looking into this, seems like I can add a if to the BaseEvent class that can satisfy this requirement

if self.host:
    if self._scope_distance_increment_same_host or not hosts_are_same:
        new_scope_distance += 1
self.scope_distance = new_scope_distance

Not sure if its as simple as this or if theres more areas that I'm overlooking

from bbot.

TheTechromancer avatar TheTechromancer commented on July 19, 2024

Hey @domwhewell-sage, are you working on this one? If not, I can take it.

from bbot.

domwhewell-sage avatar domwhewell-sage commented on July 19, 2024

Hey, I started with the if statement but the tests were returning some strange results (i.e. distance-0 for events that shouldn't be)

So it might make more sense to cast your expert eye over it @TheTechromancer

from bbot.

TheTechromancer avatar TheTechromancer commented on July 19, 2024

Roger I'll take a look

from bbot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.