Ensure support for React 16 about react-d3-tree HOT 7 CLOSED

+1! Quite a few issues mainly related to paths since updating

from react-d3-tree.

Ok, can you explain what's going on @jmorrice?

from react-d3-tree.

• All paths are being shown right away, without the corresponding nodes.
• Nodes aren't collapsing after clicking them again

I'll see if I can figure out what's going on

from react-d3-tree.

Ok interesting. That would be great if you have a few minutes 👏

Will push out a new version ASAP if you have a PR at some point, otherwise I'll investigate myself.

from react-d3-tree.

@jmorrice can't see any obvious issues after upgrading the demo to react/react-dom 16.x, could you please post the setup you're using the library in?

from react-d3-tree.

My mistake, turns out the problem was related to updating react-transition-group from 1.1.3 to 2.2.1. So we can close this issue, but shall I open another ticket for updating that package?

from react-d3-tree.

Ok, suspected that might have been the reason.

Sure feel free to open an issue for an upgrade to transition-group v2.

It should actually be declared as a peer dependency rather than a direct dependency anyways, as it can cause hard to track bugs this way.
That’s a breaking change though so will have to wait until react-d3-tree v2. Refactoring and upgrading should hopefully be possible now though.

from react-d3-tree.