Code Monkey home page Code Monkey logo

Comments (7)

bkrem avatar bkrem commented on May 16, 2024 2

Hey, haven’t had time during the week to work on the library but I’ll start on this tomorrow!
Until I get paid for open source I unfortunately have to prioritise my job 😛

from react-d3-tree.

bkrem avatar bkrem commented on May 16, 2024 1

Hey @iqbalhussain931, this is great, thanks for taking the time to make a sketch! 👏

Will try to get this implemented after work at some point this week, might take longer though if breaking changes can’t be avoided, i.e. it needs to be published as v2. Should be possible as a minor release though hopefully.

Also hey if you feel like it feel free to work on it and shoot me a PR! :)

from react-d3-tree.

iqbalhussain931 avatar iqbalhussain931 commented on May 16, 2024

I understand sure that your time @bkrem and though i am at a beginners level on react but would loved to be a part of this but surely will need your help too :)

from react-d3-tree.

iqbalhussain931 avatar iqbalhussain931 commented on May 16, 2024

Hey @bkrem
how are you? :)
just wanted to take a follow up on the feature as discussed with you.

from react-d3-tree.

henryhuang avatar henryhuang commented on May 16, 2024

@bkrem , I need this feature, because currently the styles attr is static, i think the styles should be passed with object or function, if object then use current logic, but if function, it can pass linkData to the function to return styles object. Like path render function.

from react-d3-tree.

bkrem avatar bkrem commented on May 16, 2024

Hey @henryhuang, yeah I feel your pain here. This project was originally adapted from a tight use case so there are still inflexible aspects that need ironing out.

At the moment I simply don't have the time to work on this properly due to requirements of my professional work + having 2 major features already as WIP for this project.
If you have the time to write an implementation that you think makes more sense as a whole that would be awesome!

Please be aware though that if it breaks the current styles API it'll have to go into v2 rather than as a v1.x release. If that's the case I'll clean up what's left of the v2 roadmap ASAP to push out that feature 👍

from react-d3-tree.

bkrem avatar bkrem commented on May 16, 2024

Resolved in #82, closing.

from react-d3-tree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.