Code Monkey home page Code Monkey logo

Comments (5)

aWelker avatar aWelker commented on August 22, 2024

Alternatively: Each SuperNode could maintain its own UndoManager. This would allow to switch between different parts of the graph and always be able to undo changes you did to the current environment

from grave.

bkiefer avatar bkiefer commented on August 22, 2024

To reproduce:

  • Create supernode, change into supernode, undo: NullPointerException
  • Create supernode, change into supernode, create node, change to parent, undo, undo --> node created in new supernode is now in parent

from grave.

bkiefer avatar bkiefer commented on August 22, 2024

Possible solutions:

  1. separate Undo managers for all active super nodes
    • When the supernode stack is "popped", the undo managers for the respective supernodes are dropped or not?
    • That would mean that you can only undo things in the current supernode
  2. The actions get a SuperNode field and act on the right model.
    • Issue a warning if undoing/redoing things outside the current view!?
  3. Changing the SuperNode clears the undo/redo manager. This might be an interim solution until there is a better one

from grave.

bkiefer avatar bkiefer commented on August 22, 2024

Possible solutions:

  1. separate Undo managers for all active super nodes
    • When the supernode stack is "popped", the undo managers for the respective supernodes are dropped or not?
    • That would mean that you can only undo things in the current supernode
  2. The actions get a SuperNode field and act on the right model.
    • Issue a warning if undoing/redoing things outside the current view!?
  3. Changing the SuperNode clears the undo/redo manager. This might be an interim solution until there is a better one

from grave.

bkiefer avatar bkiefer commented on August 22, 2024

fixed by 5d979d7

from grave.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.