Code Monkey home page Code Monkey logo

Comments (4)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 27, 2024
Honestly, I don't think this is very important. Those extra bytes here and 
there basically don't count for very much when you have very large media 
downloads for textures and the meshes. And if you care about minification, then 
you could simply run the emitted code through an existing JS combiner/minifier.

It's not that I don't care about minifying JS, I just don't think that it is 
core to _this_ library. I've deprioritized it, but let me know if you have a 
strenuous objection.

Original comment by wonchun on 4 Apr 2012 at 2:39

  • Added labels: Priority-Low, Type-Enhancement
  • Removed labels: Priority-Medium, Type-Defect

from webgl-loader.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 27, 2024
The more major issue is the extra commas (before } and ]). These cause problems 
with some JSON loaders. I have fixed this issue in my local code if you would 
like to see the changes (which also include the minification flag, but always 
does not have extra commas).

Original comment by [email protected] on 4 Apr 2012 at 4:15

from webgl-loader.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 27, 2024
OK, I'll get those extraneous commas out. I guess they are technically not 
legal JSON, but JSON.parse doesn't really mind.

Original comment by wonchun on 9 Apr 2012 at 10:50

  • Changed state: Started
  • Added labels: Type-Defect
  • Removed labels: Type-Enhancement

from webgl-loader.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 27, 2024
Quick update: so I plan on redoing all the JSON output to use the new JsonSink 
class. See r86.

Original comment by wonchun on 11 Apr 2012 at 6:43

from webgl-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.