Code Monkey home page Code Monkey logo

Comments (4)

milansimek avatar milansimek commented on May 18, 2024

Actually this is a better fix, the directions click listener registers twice, it can be solved as follows:

Change:

if(_this.settings.inlineDirections === true){

To:

if(_this.settings.inlineDirections === true && typeof firstRun === "undefined"){

from jquery-store-locator-plugin.

bjorn2404 avatar bjorn2404 commented on May 18, 2024

Thanks, I think I might go with the following since the origin has to exist for directions to work but either appear to fix the issue:

if(_this.settings.inlineDirections === true && typeof origin !== 'undefined'){

from jquery-store-locator-plugin.

milansimek avatar milansimek commented on May 18, 2024

Hi Bjorn,

Sounds good to me. Your version should make the code more solid for various cases.

Thanks!

from jquery-store-locator-plugin.

bjorn2404 avatar bjorn2404 commented on May 18, 2024

Updated in v2.0.6.

from jquery-store-locator-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.