Any chance for an RC5 that uses the most recent consul-client? about hazelcast-consul-discovery-spi HOT 6 CLOSED

Please submit a PR, rerun all tests before, and I'll try to get it in, thanks!

subscribing @bmudda

from hazelcast-consul-discovery-spi.

Sorry that it has taken me so long to get back to you on this. I've finally downloaded the zip and run the tests. There are significant issues. First, the following compile groups need to be added to build.gradle:

compile group: 'com.orbitz.consul', name: 'consul-client', version:'0.12.4'
compile group: 'com.fasterxml.jackson.core', name: 'jackson-core', version:'2.6.3'
compile group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version:'2.6.3'
compile group: 'com.fasterxml.jackson.core', name: 'jackson-annotations', version:'2.6.3'
compile group: 'org.glassfish.jersey.core', name: 'jersey-client', version:'2.9.1'

(note that this replaces the compile group for the older consul-client)

But the big problem is that the Consul.Builder class no longer has the method withClientBuilder() that is used in ConsulClientBuilder when consulServerHostnameVerify is false. I've apparently lucked out because the default is true so this method isn't called in my environment. The compilation fails. It unfortunately isn't as simple as just using the latest version of consul-client.

from hazelcast-consul-discovery-spi.

@pheitman

I'll take a look, will the latest hz 3.6.4 lib be an issue for you?

from hazelcast-consul-discovery-spi.

rickfast/consul-client#145

from hazelcast-consul-discovery-spi.

Done, in RC5, consul-client 0.12.5

from hazelcast-consul-discovery-spi.

Thank you! I'll give it a try next chance I get

from hazelcast-consul-discovery-spi.