Code Monkey home page Code Monkey logo

Comments (8)

bitrequest avatar bitrequest commented on September 11, 2024 1

If someone pays the exact amount from input or QR i'm pretty sure they will match. Gonna round the receiving amount to 6 decimals as well and it should be a 100% match. More then 6 decimals is only relevant for BTC at the moment cause of it's high price relative to the other crypto's but even that should be enough for now i think. And i've tested with 8 decimals and it starts having rendering problems. Think i will need to implement big number libraries for that. Which is not something i want to do in the short term.

from bitrequest.github.io.

bitrequest avatar bitrequest commented on September 11, 2024

I think i got this, sometimes it uses 5 decimals and sometimes 6. Shall i make 6 the standard?

from bitrequest.github.io.

benkaiser avatar benkaiser commented on September 11, 2024

@bitrequest can we just make it as granular as the value is (i.e. show the number up to however many decimals are non+zero)?

from bitrequest.github.io.

bitrequest avatar bitrequest commented on September 11, 2024

I think 6 decimals is good, otherwise it can go up to more then 20 decimals (When converted via Xchange rates). Which is not really userfriendly. And not practical for the UX.

from bitrequest.github.io.

benkaiser avatar benkaiser commented on September 11, 2024

@bitrequest will the 6 decimals always match what is shown with the QR code? I'm just concerned with the change in logic for exact payments, that they may not match up

from bitrequest.github.io.

benkaiser avatar benkaiser commented on September 11, 2024

(just to add, the other reason I like more decimals is that I plan on passing small differences in USD amounts to make the transactions more likely to be unique, and for BTC 6 decimals is almost 4 cents difference in USD price)

from bitrequest.github.io.

bitrequest avatar bitrequest commented on September 11, 2024

Ok i tested on all coins and had 100% match each time! (6 decimal standard)
5e6a7c8

from bitrequest.github.io.

benkaiser avatar benkaiser commented on September 11, 2024

Perfect, thanks @bitrequest !

from bitrequest.github.io.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.