Code Monkey home page Code Monkey logo

Comments (9)

Kajot-dev avatar Kajot-dev commented on September 24, 2024 1

One question I have about proxy: edge to proxyHeaders: xforwarded (or forwarded) is the arg --http-enabled true in the documentation.
Seems that the PR #27890 and #28530 don't address it by adding a flag for --http-enabled true.

https://www.keycloak.org/docs/latest/upgrading/index.html#deprecated-proxy-option

@lucasfcnunes See bitnami/containers#67957 (comment)

TLDR http-enabled is always true unconditionally in bitnami containers

from charts.

andresbono avatar andresbono commented on September 24, 2024

Hi, thank you for reporting this issue. I can reproduce it installing the bitnami/keycloak chart with default values:

$ helm install keycloak oci://registry-1.docker.io/bitnamicharts/keycloak --version 21.3.1
$ kubectl logs statefulset/keycloak

2024-05-27 09:49:32,273 WARN  [org.key.qua.run.cli.Picocli] (main) The following used options or option values are DEPRECATED and will be removed in a future release:
	- proxy: Use proxy-headers.

Although it's just a deprecation warning (for now), we can fix it in the container and chart configuration.

Some references:

The support for setting proxy modes is deprecated and will be removed in a future Keycloak release. Consider configuring accepted reverse proxy headers instead [...]

Would you like to contribute sending a PR with the changes to fix this issue? The Bitnami team will be more than happy to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

from charts.

dalbani avatar dalbani commented on September 24, 2024

I guess fixing the chart will first require fixing the Docker image, as reported at bitnami/containers#65190.

Note that Keycloak 25 introduced even more changes when it comes to hostnames: https://www.keycloak.org/2024/06/keycloak-2500-released.html#_new_hostname_options.

from charts.

andresbono avatar andresbono commented on September 24, 2024

Thank you for linking both issues. You are correct, the container image needs to be adapted as well.

from charts.

github-actions avatar github-actions commented on September 24, 2024

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

from charts.

tanadeau avatar tanadeau commented on September 24, 2024

Still true

from charts.

andresbono avatar andresbono commented on September 24, 2024

I have just set the on-hold Issues or Pull Requests with this label will never be considered stale label as bitnami/containers#65190 needs to be fixed first.

from charts.

Kajot-dev avatar Kajot-dev commented on September 24, 2024

This should be fixed with #27890 and #28530

from charts.

lucasfcnunes avatar lucasfcnunes commented on September 24, 2024

One question I have about proxy: edge to proxyHeaders: xforwarded (or forwarded) is the arg --http-enabled true in the documentation.
Seems that the PR #27890 and #28530 don't address it by adding a flag for --http-enabled true.

https://www.keycloak.org/docs/latest/upgrading/index.html#deprecated-proxy-option

from charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.