[bitnami/redis] Enable the PVC label configuration about charts HOT 6 CLOSED

Hi!

Did you try master.persistence.labels and replica.persistence.labels?

from charts.

Hi all, thanks for the help.

I will give you some context: I use the Redis Sentinel setup, here is the replica.persistence and sentinel sections of my values.yaml:

replica:
  replicaCount: 3
  persistence:
    storageClass: "gp3-retain"
    ## @param replica.persistence.accessModes Persistent Volume access modes
    ##
    accessModes:
      - ReadWriteOnce
    ## @param replica.persistence.size Persistent Volume size
    ##
    size: 8Gi
    ## @param replica.persistence.labels Additional custom labels for the PVC
    ##
    labels:
      snapshotScheduler: enabled
  resources:
    limits:
      memory: 1Gi
    requests:
      cpu: 100m
      memory: 100Mi


sentinel:
  enabled: true
  image:
    repository: bitnami/redis-sentinel
    tag: 7.2.4-debian-11-r3
    ## Enable debug mode
    ##
    debug: false
  downAfterMilliseconds: 30000
  failoverTimeout: 120000
  ## @param sentinel.masterSet Master set name
  ##
  masterSet: master
  resources:
    limits:
      memory: 500Mi
    requests:
      cpu: 100m
      memory: 100Mi

I attempted to utilize the commonLabels but it did not function as expected: the labels were not successfully added to the PVC. Furthermore, this approach does not appear to be an optimal or clean solution.

from charts.

Hi!

I see the issue. In sentinel/statefulset.yaml I see that the labels section is not set

      kind: PersistentVolumeClaim
      metadata:
        name: redis-data
        labels: {{- include "common.labels.matchLabels" ( dict "customLabels" .Values.commonLabels "context" $ ) | nindent 10 }}
          app.kubernetes.io/component: node

It should be

      kind: PersistentVolumeClaim
      metadata:
        name: redis-data
        {{- $claimLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.replica.persistence.labels .Values.commonLabels ) "context" . ) }}
        labels: {{- include "common.labels.matchLabels" ( dict "customLabels" $claimLabels "context" $ ) | nindent 10 }}
          app.kubernetes.io/component: node

Would you like to submit a PR updating the file?

from charts.

Aren't these thrown away in matchLabels? Is matchLabels the correct function here? It is not used in a match context.

from charts.

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

from charts.

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

from charts.