Controller crashed: `Observed a panic: "assignment to entry in nil map"` about sealed-secrets HOT 19 CLOSED

Hi @lindhe we're going to take a look at the issue since it's true that It can be easily reproduced.

cc: @alvneiayu @alemorcuq

from sealed-secrets.

Hi, @lindhe. We've identified the issue and have created a PR #1474 to address it. Thank you very much for reporting this and for your patience.

from sealed-secrets.

Alright, I've pretty much established that the issue here is that I have an empty secret that I try to patch using sealed secrets.

I've tried changing from sealedsecrets.bitnami.com/patch: "true" to sealedsecrets.bitnami.com/managed: "true" and then restarting the pod, but it crashes with the same error.

Scratch that. I added managed but forgot to remove patch. It works with managed but not with patched.

The reason for me having an empty secret to begin with is that it's part of the manifest I use as a base, and I thought it would be easier to just let sealed secrets patch that than having to first fiddle around with removing the secret and then creating a new one using sealed secrets. Especially since they might decide to populate that initial secret later on; if I remove it I won't get that new addition from upstream.

from sealed-secrets.

It works with managed but not with patched.

can confirm (the hard way 😅 ) that patching blank secret with -p '{"metadata": {"annotations": {"sealedsecrets.bitnami.com/patch":"true"}}}' will cause sealed secret to crash (panic thrown, but atm I don't have logs on me to point you into related LOC 😿 )

from sealed-secrets.

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

from sealed-secrets.

Still an issue in v0.24.3.

from sealed-secrets.

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

from sealed-secrets.

no bot :(

from sealed-secrets.

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

from sealed-secrets.

ping

from sealed-secrets.

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

from sealed-secrets.

not stale

from sealed-secrets.

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

from sealed-secrets.

Think it's not stale. Have not tried in a while.

from sealed-secrets.

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

from sealed-secrets.

ping

from sealed-secrets.

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

from sealed-secrets.

Ping

from sealed-secrets.

Thank you for fixing it! 👍

from sealed-secrets.