Code Monkey home page Code Monkey logo

Comments (2)

jehiah avatar jehiah commented on July 19, 2024

@johnboxall I appreciate you writing out your use case. That's extremely helpful.

The two takeaways for me are 1) you want to control upstream hostname differently to allow vhost upstreams (at Bitly we manage ports pretty strongly and run our internal services on different ports) and related to that 2) you want to encrypt the request state so you can trust it over an untrusted connection upstream. We had explored a little of that in #1 but our need disappeared so we dropped that.

Let's leave this PR focused on the Host header setting; Can you open up a separate PR for encrypting the forwarded authenticated state (X-Forwarded-User and X-Forwarded-Email). I'm also not sure off the top of my head how good upstream https urls are supported today but that feels like it is needed in that case.

from oauth2_proxy.

johnboxall avatar johnboxall commented on July 19, 2024

@jehiah I wish I saw #1 earlier haha : )

Thanks for the feedback – I'll give it a shot!

from oauth2_proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.