Code Monkey home page Code Monkey logo

Comments (1)

jondgoodwin avatar jondgoodwin commented on June 2, 2024

The referenced PR ensures that ParseError exceptions are caught and therefore do not crash the engine. The query result (Instrumentation) reflects whether the query was successfully run.

The work that remains:

  • Return exception diagnostic error message as part of the query's Instrumentation results.
  • Treat a single-term phrase in a query as a unigram term rather than an error (a comment in QueryParser::ParsePhrase shows one way to do this).

One approach to including the parse error message as part of query results:

  • Add a field to QueryInstrumentation that holds either a ParseError message or nullptr
  • Capture this error in results as part of catching the exception
  • Format this field to any outputted CSV file in a new column
  • De-allocate the error message data when QueryInstrumentation data is destroyed

from bitfunnel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.