Comments (1)
The referenced PR ensures that ParseError exceptions are caught and therefore do not crash the engine. The query result (Instrumentation) reflects whether the query was successfully run.
The work that remains:
- Return exception diagnostic error message as part of the query's Instrumentation results.
- Treat a single-term phrase in a query as a unigram term rather than an error (a comment in QueryParser::ParsePhrase shows one way to do this).
One approach to including the parse error message as part of query results:
- Add a field to QueryInstrumentation that holds either a ParseError message or nullptr
- Capture this error in results as part of catching the exception
- Format this field to any outputted CSV file in a new column
- De-allocate the error message data when QueryInstrumentation data is destroyed
from bitfunnel.
Related Issues (20)
- Linux and Windows versions of BitFunnelToolTest have different behavior. HOT 1
- ShardCostFunction has no way to specify shard density.
- Support for Wildcard or Regex Queries? HOT 2
- Support VS 2017 Build HOT 1
- Complete support for Sharding
- Establish termtable defaults for density and treatment HOT 2
- REPL fails to load index due to buffer size calculations HOT 3
- Document the bitfunnel library API HOT 3
- Doozer build fails on Utilities - TokenManagerTest line 411 HOT 1
- Upgrade GoogleTest HOT 1
- REPL "show rows" command does not list all documents/columns HOT 3
- Ubuntu Artful g++ compiler (7.2) cannot compile NativeJIT due to deprecation warning
- The proportion of ad hoc vs. explicit terms varies significantly across shards
- Change BitFunnel executable name to 'bitfunnel' for *nix users
- REPL "status" command outputs incorrect shard statistics & does not use "shard" info
- REPL shouldn't catch CheckException HOT 1
- Is this project now dormant? What is the status? HOT 2
- Replicating BitFunnel Experiments HOT 9
- not compilable on Apple Silicon (M3 in my case)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitfunnel.