Code Monkey home page Code Monkey logo

Comments (4)

thedist avatar thedist commented on August 19, 2024

I've been trying to look in to it, but it builds perfectly fine for me so is a bit hard to debug. I may try just putting all the png64 stuff into a single file rather than a folder as that's all I can think of.

from companion-module-discord-api.

Julusian avatar Julusian commented on August 19, 2024

Ooh interesting.. It works when doing it from module-local-dev, but not when a dependency of companion (inside of node_modules).. how strange

from companion-module-discord-api.

Julusian avatar Julusian commented on August 19, 2024

It looks like in module-local-dev tsc is making sure all dependency files are compiled, even if they arent referenced in the tsconfig includes (src/png64/index.ts isnt covered by the include rule).
But when in node_modules it is only compiling those in the tsconfig include.

I cant explain why it is doing this, and a quick google is not coming up with anything..
I think the easiest solution here would be to inline those files.
Also to make the line be "include": ["src/**/*.ts"], in tsconfig.json so that it will definitely compile all ts files in subdirectories.

Another thing of note, is that you have "typescript": "^4.5.5" as your devDependency (yarn.lock says it is currently 4.6.2), but are doing npx typescript@^4.2.3 in the yarn build, which for me is being done wih 4.7.4. I would recommend making them both be ~4.6 to lock it to a specific minor version number, as typescript frequently have breaking changing in minor releases. What compiles today under 4.7 may not work under 4.8, and npx typescript@^4.2.3 will be using 4.8 once it is released.

from companion-module-discord-api.

thedist avatar thedist commented on August 19, 2024

This should now be fixed.

from companion-module-discord-api.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.