Comments (6)
Thanks @molpopgen!
Yeh, it seems like there have been a few issues specifically around consts that have been getting ironed out with rustdoc
lately. It looks like they're pretty swiftly resolved though.
I'll go ahead and close this one, but please do open fresh issues for anything else you encounter!
from bitflags.
@molpopgen Did you ever get to the bottom of this? Would it be possible to share your version of rustc
you're using to build with?
from bitflags.
No, I haven't solved it. I put off an upgrade until there's another reason to bump the minor version. (The crate in question is pre-1.0 still).
❯ rustc --version
rustc 1.68.2 (9eb3afe9e 2023-03-27)
from bitflags.
Hmm, this looks like it could be a rustdoc
bug that was fixed at some point? If I upgrade tskit
to bitflags
2 and build the docs with rustc 1.70.0-nightly
I see the methods appear as const
:
If I rebuild using 1.68.2
I don't see them as const
:
They do appear to be const
though. If I add a const fn
that uses them, methods like intersects
still work.
from bitflags.
Very interesting. I'll try to confirm this myself later today. The possibility of rustdoc
bugs is definitely a weakness for using semver-checks
in one's CI :(.
from bitflags.
I confirmed this on my end -- now only the removal of from_bits_unchecked
gets flagged. I think we can close this one.
from bitflags.
Related Issues (20)
- Problems deriving serde after upgrading HOT 2
- Treatment of unknown bits in operators is inconsistent HOT 18
- Inconsistent debug output for flag with no bits HOT 4
- SWC - Update to 2.3.x causes incorrect output HOT 9
- Flagging supply-chain security issues HOT 3
- Match expression question HOT 2
- messes with dependent crates! HOT 3
- Documenting bitflags: how to get documentation for the generated bitflags HOT 4
- clippy::iter_without_into_iter HOT 3
- Feature guard `parser`? HOT 4
- Static member variable on the impl? HOT 2
- [Feature Request] `repr(packed)` for internal bits types HOT 2
- [Feature Request] Smaller internal types with non-breaking size increases HOT 3
- [Feature Request] Serialize as struct of bools HOT 2
- [Feature Request] Make Flags trait methods public HOT 1
- Please allow to use the "internal" derives in the "custom-derive" case HOT 6
- Enforce uniqueness of flags HOT 4
- FR: Please make operators cosnt. bitwise or operator `|` is not const HOT 3
- Allow specifying attributes in `impl` mode HOT 1
- `cargo doc` doesn't check for broken links in bitflags documentation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitflags.