ws public : 'candles' -- Any plan to implement it ? about bitfinex-api-node HOT 14 CLOSED

its not in the backlog, but happy to accept contributions!

from bitfinex-api-node.

@Tetradeca are you happy to submit a PR containing your candles addition? That would be great!

from bitfinex-api-node.

Sure I can do that

from bitfinex-api-node.

hi, line 113 you forgot event as second parameter

from bitfinex-api-node.

Ah indeed, thanks!

from bitfinex-api-node.

Cool !

from bitfinex-api-node.

Still got this error, not sure where it comes from.
TypeError: Cannot read property 'fundingCurrencies' of undefined
Edit: The symbol of the event returned by Bitfinex is undefined. This is a problem on their server.
{ channel: 'candles', chanId: xxx, symbol: undefined }

from bitfinex-api-node.

Ah yes, that's why I was not passing the event actually. I fixed it correctly on another branch I made but it had a very different structure, let me see what I can do.

from bitfinex-api-node.

Thank you dude, I did a workaround by manually specifying the pair. So the candles only work one pair at a time.

from bitfinex-api-node.

Actually it might have been simpler than that, can you try updating with my latest commit?

from bitfinex-api-node.

I have already implemented my workaround and it works. I will try your version when I need candle multipairs.
If your version works, maybe you could try submitting a push request ?

from bitfinex-api-node.

It's already proposed as a PR, but I think the repo owner is a bit overwhelmed elsewhere.

from bitfinex-api-node.

Hey folks,

thank you for being patient, I was swamped with other work.

I just merged the candles work @Tetradeca provided :)

from bitfinex-api-node.

event.symbol is still undefined

from bitfinex-api-node.