Code Monkey home page Code Monkey logo

Comments (3)

robertkowalski avatar robertkowalski commented on June 2, 2024

Hello and thanks for reporting!

I'm not sure if I can follow, can you elaborate please what the error is and how it happens for you?

Thank you in advance!

from bitfinex-api-node.

TestniTester avatar TestniTester commented on June 2, 2024

if you open orderbook.js (examples)
the orders in orderbook array are not properly sorted...
if you look up my example, all orders in ALL orderbooks should be sorted by price....
BIDS descending, ASKS ascending...
right?
her...they are mot properly sorted
2734,4
2734,8
2734,3
2736,9
should acualy be
2734,3
2734,4
2734,8
2736,9
right?

from bitfinex-api-node.

robertkowalski avatar robertkowalski commented on June 2, 2024

You raise a good point.

In JavaScript just plain Arrays guarantee sorting order, the example does not provide a sorted orderbook and uses a hashmap like structure for fast inserts and deletes.

It's easy to get the prices with Object.keys as an array and use .sort to make it sorted ascending or descending.

I'm busy with some other fixes right now, but I opened #84

from bitfinex-api-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.