Doesn't work on NodeJS 12 about tiny-secp256k1 HOT 10 CLOSED

Also: #26 seems like a good idea... people will see the error logs, but using optionalDependencies we can at least pass your tests with the javascript implementation.

from tiny-secp256k1.

I fixed it.
#39

from tiny-secp256k1.

bcoin-org/bcrypto#7

Looks like v12 finally removed a bunch of functionality that we make heavy use of...

For now, use a node version < v12.

v10 LTS will be supported until April 2021. But it's nice to have this here for priorities.

Thanks for the report.

from tiny-secp256k1.

I reported NaN issues to the NaN repo, we will need a fix from them before we can work on this:

nodejs/nan#849 (comment)

Here's the list of problems we can fix: Basically just stop using v8::Value::BooleanValue()

../native/addon.cpp: In function ‘Nan::NAN_METHOD_RETURN_TYPE ecdsaVerify(Nan::NAN_METHOD_ARGS_TYPE)’:
../native/addon.cpp:284:34: error: no matching function for call to ‘v8::Value::BooleanValue()’
   strict = info[3]->BooleanValue();

../native/addon.cpp:81:38: error: no matching function for call to ‘v8::Value::BooleanValue()’
   return info[index]->BooleanValue() ? SECP256K1_EC_COMPRESSED : SECP256K1_EC_UNCOMPRESSED;

../native/addon.cpp:81:38: error: no matching function for call to ‘v8::Value::BooleanValue()’
   return info[index]->BooleanValue() ? SECP256K1_EC_COMPRESSED : SECP256K1_EC_UNCOMPRESSED;

../native/addon.cpp:88:38: error: no matching function for call to ‘v8::Value::BooleanValue()’
   return info[index]->BooleanValue() ? SECP256K1_EC_COMPRESSED : SECP256K1_EC_UNCOMPRESSED;

from tiny-secp256k1.

In the meantime can we set the max version to < 12 here?

https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/package.json#L8

from tiny-secp256k1.

Why there? Why not here?

How would this help if the result is a failed install either way?

from tiny-secp256k1.

Ooops, I'm sorry, I think was looking at a different repo when I copy and pasted that. Yeah I mean here.

I think for me, it wasn't pleasant hunting down why my heroku deployment failed though I have no problem setting node version of my package anyways. Just thought it might help those in the meantime if/when tiny-secp256k1 supports the changes introduced by node12.

from tiny-secp256k1.

https://github.com/nodejs/node-gyp/blob/master/CHANGELOG.md#v400-2019-04-24
goodnews

from tiny-secp256k1.

Looks like secp256k1-node have a fix that could be ported here?
cryptocoinjs/secp256k1-node#143

from tiny-secp256k1.

Fixed in v1.1.1 thanks to @Xmader !

Thanks a lot!

from tiny-secp256k1.