Code Monkey home page Code Monkey logo

Comments (4)

landabaso avatar landabaso commented on June 8, 2024

Hi @saravanan7mani, thank you for bringing this to my attention.

I've aimed to minimize the number of types exported, with the intention that they should be implicitly set. For instance, in const expansionMap = output.expand().expansionMap, the type is inferred by TypeScript, so an explicit declaration isn't necessary.

However, I'm open to the idea of exposing these types. Could you please clarify the specific circumstances under which you needed each one? For example, I'm curious about your need for TimeConstraints. This is an internal type, and its external usage isn't clear. If we expose it and subsequently change the API, it could result in a breaking change. Understanding your use case will help me make an informed decision.

Looking forward to your response.

from descriptors.

saravanan7mani avatar saravanan7mani commented on June 8, 2024

Hi @landabaso, thank you for the response.

  1. As a function argument types, they are useful. Ex: processExpansionMap(expansionMap: ExpansionMap) and validatePreimage(preimage: Preimage).

  2. Please ignore TimeConstraints and ParseKeyExpression. I just copied them from types.ts without thought.

from descriptors.

landabaso avatar landabaso commented on June 8, 2024

Are you in need of an immediate fix for this? For now, you might need to manually copy the types. I plan to address this in the next release and will keep the issue open until then. Is this approach workable for you?

from descriptors.

saravanan7mani avatar saravanan7mani commented on June 8, 2024

Yep. Works for me.

from descriptors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.