Comments (4)
Hi @saravanan7mani, thank you for bringing this to my attention.
I've aimed to minimize the number of types exported, with the intention that they should be implicitly set. For instance, in const expansionMap = output.expand().expansionMap
, the type is inferred by TypeScript, so an explicit declaration isn't necessary.
However, I'm open to the idea of exposing these types. Could you please clarify the specific circumstances under which you needed each one? For example, I'm curious about your need for TimeConstraints
. This is an internal type, and its external usage isn't clear. If we expose it and subsequently change the API, it could result in a breaking change. Understanding your use case will help me make an informed decision.
Looking forward to your response.
from descriptors.
Hi @landabaso, thank you for the response.
-
As a function argument types, they are useful. Ex:
processExpansionMap(expansionMap: ExpansionMap)
andvalidatePreimage(preimage: Preimage)
. -
Please ignore
TimeConstraints
andParseKeyExpression
. I just copied them fromtypes.ts
without thought.
from descriptors.
Are you in need of an immediate fix for this? For now, you might need to manually copy the types. I plan to address this in the next release and will keep the issue open until then. Is this approach workable for you?
from descriptors.
Yep. Works for me.
from descriptors.
Related Issues (20)
- add compatibility with Ledger HOT 1
- Add new methods HOT 6
- Refactor DescriptorsLibrary HOT 1
- WIF or xprv keyExpressions should automatically sign the Psbt
- `updatePsbt` throws an Error when attempting to add another UTXO belonging to the same timelocked descriptor/address HOT 4
- `sortedmulti` nestedn in `wsh`? HOT 1
- Forced to invoke the construtor and instantiate a new object every time I want to increment an address index HOT 1
- Lookbehind in regexp not supported on iOS HOT 4
- Error: cannot finalize psbt index 0 since it does not correspond to this descriptor HOT 5
- Support for `@scure/btc-signer` HOT 1
- Output descriptor with both receiving and change paths HOT 4
- Master key prefix m is added to non-master xpub's path HOT 5
- new Output with descriptor: addr(TAPROOT) HOT 6
- Remove bitcoinCoreFixtures.js from git; it's generated automatically HOT 1
- support multiple wildcards, and pass an array of indices
- Take into account Resource Limitations HOT 1
- Run createcreateFixtures.js before tests are run
- Handle BIP 32 path element overflow
- Return key origin HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from descriptors.