Comments (5)
Sure, that's fairly easy to add. One question though: importing should be pretty easy for us, but should we also export descriptors that contains operators not (currently) supported by Core?
Because in your spec it's pretty clear that the descriptor should be a "Bitcoin Core" descriptor, and these are not :/
from bdk.
Do you have some docs that describe those?Would be happy to add support for them if I can.
from bdk.
I'm not sure it's that easy unfortunately, you would probably have to change quite a few things in Core.
This project uses rust-miniscript as its "descriptor engine", but I don't think they have documented anywhere the list of operators they support (the link here refers to the enum in their codebase that has every possible node in the AST). But it's pretty similar to the C++ version of miniscript, so you can have a look here and it should be more or less the same.
There are many operators that, afaik, are not in Core, like older()
, after()
, all the hash types, and even control flow operators like and_*()
etc.
from bdk.
hmmm isn't miniscript a totally different thing? I did not know you were referring to miniscript when your docs say descriptors.
It looked like from your docs you do support Bitcoin Core descriptors, some inter wallet compatibility is better then none ;-) You could just add the export functionality for Bitcoin Core compatible descriptors which you do seem to support.
from bdk.
Well, yeah, the miniscript langauge is a totally different thing, but it can be compiled down to "descriptors" which is what I'm using in this project. Basically I'm using rust-miniscript to parse the descriptor, so I get for free support for all these other operators.
This is still not 100% compatible with Bitcoin Core (meaning that there are things in Core that are not supported here), but it's getting there and there are just a few minor things missing. So most of the time yes, you can import a descriptor from Core in here, but the other way around is much harder since as you can see there are many things missing from Core that are available here.
You could just add the export functionality for Bitcoin Core compatible descriptors which you do seem to support.
Yeah I can try to do that, I'll just have to define the right criteria to decide whether a descriptor is supported by Core or not, but it shouldn't be too hard.
from bdk.
Related Issues (20)
- Introduce `bdk_persist` crate HOT 2
- need custom lookahead HOT 2
- Release 1.0.0-alpha.10 HOT 1
- Unable to `calculate_fee` when syncing with electrum HOT 1
- Upgrade rust-bitcoin to 0.32 HOT 8
- Add support for testnet4
- Create nightly job to bump clippy rust version
- Use `bitcoin::Amount` everywhere HOT 3
- ci: cronjob to bump the pin on clippy HOT 2
- example: Fix wallet examples HOT 3
- Release 1.0.0-alpha.11 HOT 2
- Help spending a tr aggregated key using musig2 HOT 5
- txout_index, `Descriptor` not needed in `keychains_to_descriptors`
- InsufficientFunds is duplicated within coin_selection::Error and CreateTxError enums HOT 1
- More tests for `bdk_electrum` fee calculation HOT 1
- Create a `bdk_floresta` chain source crate HOT 3
- `Wallet::insert_tx` should not have `position` input HOT 2
- Human Readable Names Support
- Release 1.0.0-alpha.12 HOT 1
- Add user-facing events for applying updates after syncing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bdk.