Code Monkey home page Code Monkey logo

Comments (4)

theuni avatar theuni commented on June 28, 2024

@sipa now that we have automake and can select the proper input files based on configure, would you be interested in moving the _impl.h -> _impl.c, then building the necessary objects based on make directives, rather than include magic?

That would help in this case, as well as in modularizing a bit. As an easy-to-see win, the test program could then run against all implementations at once.

If that's not a goal, then we can just take the shortcut here and link in the asm object in that case.

from secp256k1.

sipa avatar sipa commented on June 28, 2024

@theuni That breaks the compiler's ability to inline, which we're strongly relying upon. I haven't tested the performance hit, so I may be overestimating it.

from secp256k1.

theuni avatar theuni commented on June 28, 2024

@sipa Understood. I'd like to discuss that, but this issue isn't the place for it. I'll PR the simple fix for this one.

from secp256k1.

sipa avatar sipa commented on June 28, 2024

Fixed by #55.

from secp256k1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.