Comments (3)
Hey @webmaster128, thanks for opening an issue!
Thanks, I should improve the documentation on validatePrivateKey
to clarify the functionality there. There's a short note here on it – basically, I want to avoid adding any runtime checks which aren't necessary for 100% of consumers.
For most applications, when a potential new key is generated, it should be 32 bytes in length, so also validating the length in validatePrivateKey
would be extraneous.
Ideally, TypeScript will eventually support stronger type guarantees about the length of a typed array so our function signature can specifically require a 32-byte Uint8Array (microsoft/TypeScript#18471). This would never be an error at runtime, because the compiler should be able to catch any instance in which the programmer accidentally generated the wrong size key (or failed to validate the length of a user-provided key), and those errors should never make it to runtime.
from libauth.
👍 makes sense, thanks. If I know that, I can easily do the check in my own code.
from libauth.
Merging into #3, which I think probably handles this best.
from libauth.
Related Issues (20)
- V2 branch: compileOutputTemplate does not respect `token` HOT 9
- can't find importAuthenticationTemplate? HOT 3
- BTC opcodes still present after tree-shaking
- Upgrading from 1.19.1 to 2.0.0-alpha.8 issues with the import HOT 1
- Gmp HOT 2
- Is running inside a browser really supported? HOT 2
- `generateRandomBytes` should throw on duplicate results across two runs
- Unable to find useful examples
- [2023.05 protocol upgrade]. Reject future transaction versions
- Research: v5 transaction format HOT 1
- createInstructionSetBCHCHIPs uses isStandardOutputBytecode rather than isStandardOutputBytecode2023 HOT 1
- Issue with tree-shaking in a project using Libauth HOT 7
- Issue on Safari : Promise Rejection: ReferenceError: Cannot access uninitialized variable. HOT 3
- Conflicting re-exports
- Question regarding signing and verifying messages HOT 1
- Custom libsecp256k1 is hard to merge with upstream HOT 7
- replace bitbox with libauth
- generatePrivateKey only has one parameter (secureRandom) and not two parameters (secp256k1, secureRandom) as indicated in the documentation.
- Add links to Examples in the README HOT 1
- How to create multisig address and spend it?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libauth.