Code Monkey home page Code Monkey logo

Comments (2)

tlvu avatar tlvu commented on August 16, 2024 1

My bad, I did not see this loader order problem in my previous review of #296

For context, the load order is important by design because it allows for the override capabilities describe here

# Last dir/component in the EXTRA_CONF_DIRS list have highest override
# precedence, example:
#
# * Last docker-compose volume mount to same destination win over the
# previous docker-compose volume mount.
#
# * Last default.env can change the values of all previous default.env.
#
# * Last pre/post docker-compose-up script can potentially undo actions
# from previous scripts.
#
# Suggested to keep the private-config-repo last in the list to be able to
# override anything.

Each org private config, which is suggested to be the last component in the list, should be able to override all previous docker-compose fragments, all previous default.env values and all previous pre/post docker-compose-up scripts.

This component override capabilities, together with env.local, are basically the customization feature allowing each org to change any default behaviors.

from birdhouse-deploy.

mishaschwartz avatar mishaschwartz commented on August 16, 2024

@fmigneault I've put up a PR with a fix for the load order issue.

I am unable to replicate the issue regarding the missing ./optional-components/canarie-api-full-monitoring/docker-compose-extra.yml file. That file loads fine when I test it out on my local test environment. I'm using the same EXTRA_CONF_DIRS variable that you have above and the code is currently on the master branch. If that continues to be a problem my guess is that it is unrelated to the load order issue.

The load order is not random, the docker-compose-extra.yml file defined at the root of each component's directory is loaded first. Once all of these are loaded, any overrides that are defined in config/*/docker-compose-extra.yml are loaded.

from birdhouse-deploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.