Use of debugbreak should be opt-in about rapidyaml HOT 3 CLOSED

the tar.gz of c4core 0.11.0 available on github does not contain files from external repositories

When a release is made, the auto-generated source tarball from github unfortunately never includes submodule repos. So you need to pick a different file to get a properly working source tarball:

This also applies to the rapidyaml repo. If you pick the equivalent rapidyaml file, it will bring the c4core source, and there's no reason for you to have to get c4core separately.

but why would a yaml library call __debugbreak ?

Fair point.

rapidyaml uses c4core, and c4core provides/uses debugbreak in debug builds. I chose to put it as opt-out because I use it heavily when debugging. In release builds, it goes away (and if it doesn't that's a bug), which is generally what most users will be looking for. So I never found it to be on my way.

However, on hindsight, I agree that it should be opt-in. I will revise that, and leave this issue open to track that.

For the C-cast warnings, let's track it in a different issue.

from rapidyaml.

• I have to #pragma GCC diagnostic ignored "-Wold-style-cast" to inhibit some g++ warnings.

from rapidyaml.

Thank you for the explanation about the tar files.

from rapidyaml.