Required properties about binance-api-swagger HOT 4 CLOSED

Thank you @performanceArtist, this will be included in next release.

from binance-api-swagger.

Hey @performanceArtist, this project's target is Swagger UI, but we can consider adding more openAPI specs for local code generation use cases.
Everything under schemas is for different responses' json content and all its properties are required. Testing with openapi-typescript tool, it seems to generate all the properties correctly, can you share how you're generating your local code, pls?

from binance-api-swagger.

Testing with openapi-typescript tool, it seems to generate all the properties correctly

All the properties in responses[200] section are optional, which is not correct - this is exactly what I was talking about. For example:

        /** Average price */
        200: {
          content: {
            "application/json": {
              mins?: number;
              price?: string;
            };
          };
        };

And here's how the schemas look after generation, everything is also optional:

export interface components {
  schemas: {
    account: {
      makerCommission?: number;
      takerCommission?: number;
      buyerCommission?: number;
      sellerCommission?: number;
      canTrade?: boolean;
      canWithdraw?: boolean;
      canDeposit?: boolean;
      updateTime?: number;
      accountType?: string;
      balances?: {
        asset?: string;
        free?: string;
        locked?: string;
      }[];
    };

Regardless of a generation tool chosen, it should mark these properties as optional, since it is implied by the absence of required.

from binance-api-swagger.

we can consider adding more openAPI specs for local code generation use cases

Is there any point in separating? Adding required would only make the spec more accurate. And it should not affect the ui.

from binance-api-swagger.