Tests compile steps not pass to run. An error with case : error: comparison between signed and unsigned integer expressions. about balgo HOT 6 CLOSED

The reason is that the two arguments in EXPECT_EQ have different types: one is signed integer and the other is unsigned. Maybe you can show me your code.

from balgo.

Data type is unsigned int by ``unsigned int value_one = 1, instead of 1 or 2 of integer type in trie_traits_test.cpp file.

unsigned int value_one = 1;
unsigned int value_two = 2;
TEST(UIntTraits, Traits) {
  EXPECT_EQ(value_one, sizeof(UIntTraits<1>::UInt));
  EXPECT_EQ(value_two, sizeof(UIntTraits<2>::UInt));
  ....
}

In additional, it's can casting type of them to unsigned int type with
EXPECT_EQ(static_cast<unsigned int>(1), sizeof(UIntTraits<1>::UInt));.
I see UnitTraits<1>::UInt from typedef typename UIntTraits<sizeof(Char)>::UInt UChar; on balgo/trie/trie_traits.h file name. It have declared unsigned integer of data type.

from balgo.

It's very strange that you got an "comparison between signed and unsigned integer expressions" error, because value_one and the return type of sizeof are both unsigned integer. I don't know why.
Are you sure the error line "trie_traits_test.cpp:33" is "EXPECT_EQ(value_one, sizeof(UIntTraits<1>::UInt));" ?

from balgo.

In trie_traits.h header file declared the data types of unsigned integer such as uintBit_t. I regress test with EXPECT_EQ(value_one, sizeof(UIntTraits<1>::UInt)); is okay in result test. It's result like declared the static casting type by EXPECT_EQ(static_cast<unsigned int>(1), sizeof(UIntTraits<1>::UInt));.

from balgo.

I misunderstood what you mean before, now I got it.
I have updated the code and added some more strict compiling options.
My solution is just replacing 1 with 1U.
Thank you for reminding me of that.

from balgo.

Okay, It should close issues by set 1U that supported data type unsigned integer.

from balgo.